-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bulk open links shortcut #419
Conversation
@Tony-MK please check the tests. some of them failed. |
Thanks @LucasXu0, I am currently trying to fix them, then it will be ready for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
- Coverage 80.61% 79.85% -0.77%
==========================================
Files 255 275 +20
Lines 10441 11474 +1033
==========================================
+ Hits 8417 9162 +745
- Misses 2024 2312 +288
☔ View full report in Codecov by Sentry. |
...rc/editor/editor_component/service/shortcuts/command_shortcut_events/open_links_command.dart
Outdated
Show resolved
Hide resolved
d028d22
to
d1b7500
Compare
Sorry for the wait, @LucasXu0. I don't think I have any better ideas. Your suggestions are good.
What difference does it make if the function loops through |
@Tony-MK You're right. It would be better to call the "open link" function after the loop.
|
Thanks @LucasXu0, I will commit the changes ASAP. |
eb58b7d
to
9df2810
Compare
9df2810
to
74dba32
Compare
* main: chore: refactor attribute comparison in Delta class diff loop (AppFlowy-IO#456) fix: duration cannot be zero in animate (AppFlowy-IO#452) chore: update Chinese l10n (AppFlowy-IO#445) fix: sometimes failed to paste content from google translation (AppFlowy-IO#451) feat: refactor color conversion method to handle RGB and hex formatsRefactor method to handle RGB and hex formats, improving color conversion (AppFlowy-IO#450) fix: unable to paste html contains section (AppFlowy-IO#448) fix: remove unused check in non_delta_input_service (AppFlowy-IO#447) feat: optimize the performance (AppFlowy-IO#442) refactor: migrate tests (AppFlowy-IO#438) feat: bulk open links shortcut (AppFlowy-IO#419) fix: request focus in find replace menu (AppFlowy-IO#440) feat: implement delta diff and provide external values (AppFlowy-IO#444)
Created a keyboard shortcut to bulk open selected links in a document.
Reference issue: #2323