-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: delete node does not propagate non null selection #45
Conversation
Hey, @squidrye. Not every delete can assign the Before After |
Thanks for pointing that out, I'll see what can be done. |
I have added a condition to check if node being deleted is currently selected node, if so after-selection will not be updated, but if node being deleted is not selected and some node in background is selected it will be propagated and maintained. |Node 1| |Node 1| <- deleted then Let me know if I am missing something else here. |
Hey, @squidrye. Please format your code. |
Codecov Report
@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 82.04% 82.66% +0.62%
==========================================
Files 124 124
Lines 7179 7189 +10
==========================================
+ Hits 5890 5943 +53
+ Misses 1289 1246 -43
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* fix: delete node does not propagate non null selection * test: delete node does not propagate non null selection * refactor: lucas's suggestion * refactor: suggestions * refactor: revert inSelection, is not able to differentiate between overlays and selection. * test: updated tests * refactor: code formatting * refactor: code formatting * chore: dart format --------- Co-authored-by: Lucas.Xu <lucas.xu@appflowy.io>
fixes #39