Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust the loading large document optimization in mobile platform #474

Merged

Conversation

LucasXu0
Copy link
Collaborator

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-09-17.at.15.48.12.mp4

@LucasXu0
Copy link
Collaborator Author

closes #455

@LucasXu0 LucasXu0 force-pushed the optimization_adjustment_in_mobile branch from c4bc23e to a753a05 Compare September 17, 2023 08:12
@LucasXu0 LucasXu0 force-pushed the optimization_adjustment_in_mobile branch from a753a05 to eedf6a9 Compare September 17, 2023 10:36
@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Patch coverage: 3.70% and project coverage change: +0.30% 🎉

Comparison is base (1944ab7) 80.42% compared to head (eedf6a9) 80.72%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
+ Coverage   80.42%   80.72%   +0.30%     
==========================================
  Files         281      281              
  Lines       11683    11645      -38     
==========================================
+ Hits         9396     9401       +5     
+ Misses       2287     2244      -43     
Files Changed Coverage Δ
...nt/service/selection/mobile_selection_service.dart 17.14% <0.00%> (+2.85%) ⬆️
.../src/render/selection/mobile_selection_widget.dart 100.00% <ø> (ø)
...ditor_component/service/scroll_service_widget.dart 80.26% <33.33%> (-0.51%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit ace17c9 into AppFlowy-IO:main Sep 17, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant