Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UI issues #530

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix: UI issues #530

merged 1 commit into from
Oct 11, 2023

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Oct 11, 2023

  • the cursor will be blocked if the background color of the text isn't transparent.
Screenshot 2023-10-11 at 15 21 30 Screenshot 2023-10-11 at 15 21 47
  • expand the background color of the block component
Screenshot 2023-10-11 at 15 20 19 Screenshot 2023-10-11 at 15 19 42

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (b5f8bd1) 80.20% compared to head (9202894) 80.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
+ Coverage   80.20%   80.27%   +0.06%     
==========================================
  Files         282      282              
  Lines       11999    12029      +30     
==========================================
+ Hits         9624     9656      +32     
+ Misses       2375     2373       -2     
Files Coverage Δ
...component/selection/block_selection_container.dart 100.00% <100.00%> (ø)
...block_component/bulleted_list_block_component.dart 92.68% <100.00%> (ø)
...ading_block_component/heading_block_component.dart 92.10% <100.00%> (+0.10%) ⬆️
...block_component/numbered_list_block_component.dart 93.10% <100.00%> (+0.16%) ⬆️
...aph_block_component/paragraph_block_component.dart 98.59% <100.00%> (ø)
...t/quote_block_component/quote_block_component.dart 91.17% <100.00%> (+0.26%) ⬆️
...tor/block_component/standard_block_components.dart 100.00% <100.00%> (ø)
...ist_block_component/todo_list_block_component.dart 87.64% <100.00%> (+0.28%) ⬆️
...ib/src/editor/editor_component/service/editor.dart 100.00% <100.00%> (ø)
...component/service/ime/non_delta_input_service.dart 83.33% <100.00%> (ø)
... and 6 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 31403c9 into AppFlowy-IO:main Oct 11, 2023
9 of 10 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Oct 12, 2023
* main:
  fix: unable to clear the style by toggling twice (AppFlowy-IO#532)
  fix: pinyin IME on Linux (AppFlowy-IO#531)
  fix: background color issues (AppFlowy-IO#530)
  fix: cursor blink at wrong location when inserting text (AppFlowy-IO#529)
  feat: enable toggling and canceling of the formatting with shortcuts (AppFlowy-IO#528)
  chore: bump version 1.4.4 (AppFlowy-IO#527)
  fix: the selection handles remain on the screen after cutting the text (AppFlowy-IO#526)
  fix: the selection should be clear if header or footer is focusing (AppFlowy-IO#525)
  feat: customize desktop toolbar style (AppFlowy-IO#519)
  feat: add regex and case sensitive to `FindReplaceMenu` (AppFlowy-IO#480)
  feat: export JSON in mobile and update mobile_example.json (AppFlowy-IO#515)
  feat: support customizing error block (AppFlowy-IO#524)
  fix: impossible to click on any sub-items if the top level item is off-screen (AppFlowy-IO#522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant