fix: check if header exists for footer #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
==========================================
+ Coverage 80.35% 80.54% +0.18%
==========================================
Files 285 286 +1
Lines 12173 12182 +9
==========================================
+ Hits 9782 9812 +30
+ Misses 2391 2370 -21
☔ View full report in Codecov by Sentry. |
Xazin
reviewed
Oct 29, 2023
lib/src/editor/editor_component/entry/page_block_component.dart
Outdated
Show resolved
Hide resolved
|
@MayurSMahajan please include the tests.
|
|
I've added tests and refactored the condition of the if-statement, I'll merge once I see all green in the CI. |
q200892907
added a commit
to q200892907/appflowy-editor
that referenced
this pull request
Nov 3, 2023
* main: fix: check if header exists for footer (AppFlowy-IO#559) feat: show placeholder override for paragraph block (AppFlowy-IO#571) chore: refactor character replacement (AppFlowy-IO#570) chore: rename shortcut folder (AppFlowy-IO#569) fix: image copy error width/height is double (AppFlowy-IO#566)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #558