Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Solve the left and right key bug. #584

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

q200892907
Copy link
Contributor

Solve the left and right key bug. When adding an input box at the head or tail of the editor, it cannot be moved.

… head or tail of the editor, it cannot be moved.
@q200892907 q200892907 mentioned this pull request Nov 9, 2023
Copy link
Collaborator

@Xazin Xazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -52,8 +51,7 @@ class KeyboardServiceWidgetState extends State<KeyboardServiceWidget>
return true;
},
);
editorState.service.selectionService
.registerGestureInterceptor(interceptor);
editorState.service.selectionService.registerGestureInterceptor(interceptor);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like your formatting options are different than default 80 character line length.

@LucasXu0
Copy link
Collaborator

@q200892907 The format step failed. PTAL.

@q200892907
Copy link
Contributor Author

@q200892907 The format step failed. PTAL.

Restored default format

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b1a3d5) 80.54% compared to head (344a3b3) 80.51%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
- Coverage   80.54%   80.51%   -0.04%     
==========================================
  Files         286      286              
  Lines       12182    12232      +50     
==========================================
+ Hits         9812     9848      +36     
- Misses       2370     2384      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 467530d into AppFlowy-IO:main Nov 15, 2023
9 of 11 checks passed
@q200892907 q200892907 deleted the fix-arrow_left_or_right branch November 15, 2023 03:56
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Nov 15, 2023
* main:
  fix: solve the left and right key bug.  (AppFlowy-IO#584)
  feat: toggle format on mobile (AppFlowy-IO#587)
  feat: support toggling format style when the selection is collapsed (AppFlowy-IO#586)
  chore: release 2.0.0-beta.1 (AppFlowy-IO#582)
  feat: support Flutter stable channel (AppFlowy-IO#581)

# Conflicts:
#	lib/src/editor/editor_component/service/ime/non_delta_input_service.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants