Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize editing experience on mobile #592

Merged
merged 4 commits into from
Nov 15, 2023

chore: update mobile toolbar layout

75ea5e3
Select commit
Loading
Failed to load commit list.
Merged

feat: optimize editing experience on mobile #592

chore: update mobile toolbar layout
75ea5e3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 15, 2023 in 0s

79.20% (-1.28%) compared to 784fde1

View this Pull Request on Codecov

79.20% (-1.28%) compared to 784fde1

Details

Codecov Report

Attention: 205 lines in your changes are missing coverage. Please review.

Comparison is base (784fde1) 80.47% compared to head (75ea5e3) 79.20%.

Files Patch % Lines
...b/src/editor/toolbar/mobile/mobile_toolbar_v2.dart 0.00% 129 Missing ⚠️
...bile/toolbar_items/blocks_mobile_toolbar_item.dart 0.00% 35 Missing ⚠️
..._items/text_decoration_mobile_toolbar_item_v2.dart 0.00% 29 Missing ⚠️
lib/src/editor/toolbar/mobile/mobile_toolbar.dart 72.41% 8 Missing ⚠️
...rc/editor/toolbar/mobile/mobile_toolbar_style.dart 77.77% 2 Missing ⚠️
...mobile/toolbar_items/link_mobile_toolbar_item.dart 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
- Coverage   80.47%   79.20%   -1.28%     
==========================================
  Files         286      289       +3     
  Lines       12199    12424     +225     
==========================================
+ Hits         9817     9840      +23     
- Misses       2382     2584     +202

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov