Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selection menu positioning on right half of editor #600

Merged
merged 1 commit into from
Nov 23, 2023
Merged

fix: selection menu positioning on right half of editor #600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/src/editor/selection_menu/selection_menu_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,8 @@ class SelectionMenu extends SelectionMenuService {

void calculateSelectionMenuOffset(Rect rect) {
// Workaround: We can customize the padding through the [EditorStyle],
// but the coordinates of overlay are not properly converted currently.
// Just subtract the padding here as a result.
// but the coordinates of overlay are not properly converted currently.
// Just subtract the padding here as a result.
const menuHeight = 200.0;
const menuOffset = Offset(0, 10);
final editorOffset =
Expand Down Expand Up @@ -223,13 +223,13 @@ class SelectionMenu extends SelectionMenuService {
}

// show on left
if (_offset.dx > editorWidth / 2) {
if (_offset.dx - editorOffset.dx > editorWidth / 2) {
_alignment = _alignment == Alignment.topLeft
? Alignment.topRight
: Alignment.bottomRight;

_offset = Offset(
editorWidth - _offset.dx,
editorWidth - _offset.dx + editorOffset.dx,
_offset.dy,
);
}
Expand Down