Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: markdown does not support nested lists #611

Merged
merged 3 commits into from
Dec 7, 2023
Merged

fix: markdown does not support nested lists #611

merged 3 commits into from
Dec 7, 2023

Conversation

JessicaJHee
Copy link
Contributor

@JessicaJHee JessicaJHee commented Dec 3, 2023 •
edited
Loading

@JessicaJHee
fix: markdown does not support nested lists
6e4027a 
Signed-off-by: Jessica He <jessicahe4741@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Dec 3, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JessicaJHee JessicaJHee marked this pull request as draft December 3, 2023 23:43
@JessicaJHee JessicaJHee marked this pull request as ready for review December 4, 2023 01:58
@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8bbb3a0) 78.62% compared to head (382c059) 78.66%.

Files Patch % Lines
...ns/markdown/decoder/document_markdown_decoder.dart 94.59% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
+ Coverage   78.62%   78.66%   +0.04%     
==========================================
  Files         291      291              
  Lines       12578    12611      +33     
==========================================
+ Hits         9889     9920      +31     
- Misses       2689     2691       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit f4834b5 into AppFlowy-IO:main Dec 7, 2023
11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Dec 8, 2023
@q200892907
Merge branch 'main' into feat-zhiya
2838af6 
* main:
  fix: input chinese issue (AppFlowy-IO#608)
  fix: markdown does not support nested lists (AppFlowy-IO#611)
  chore: upgrade to flutter 3.16 (AppFlowy-IO#614)
  feat: support get the after text decorate from textSpanDecorator (AppFlowy-IO#612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Markdown exports and imports do not consider nested lists
3 participants
@JessicaJHee @CLAassistant @LucasXu0