feat: add markdown divider encoder parser #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@hamishjohnson Please fix the ci issues. |
|
@LucasXu0 Fixed the test - how can I fix the commit message without force push? |
|
@hamishjohnson I can squashed your commits, so no need to fix the commit message this time. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
==========================================
- Coverage 78.13% 76.70% -1.43%
==========================================
Files 291 294 +3
Lines 12763 12973 +210
==========================================
- Hits 9972 9951 -21
- Misses 2791 3022 +231 ☔ View full report in Codecov by Sentry. |
LucasXu0
reviewed
Jan 5, 2024
| String transform(Node node, DocumentMarkdownEncoder? encoder) { | ||
| final children = encoder?.convertNodes(node.children); | ||
| String markdown = '---\n'; | ||
| if (children != null && children.isNotEmpty) { |
There was a problem hiding this comment.
The children of the divider node must be empty.
|
Just removed that code completely now |
q200892907
added a commit
to q200892907/appflowy-editor
that referenced
this pull request
Jan 10, 2024
* main: fix: move cursor up/down issue (AppFlowy-IO#657) fix: chinese IME feat: add markdown divider encoder parser (AppFlowy-IO#639) feat: support updating cursor position via spacebar (AppFlowy-IO#655) feat: support customizing cursor width (AppFlowy-IO#654)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a markdown divider node encoder parser