Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve android selection gesture #647

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Jan 5, 2024

  • Extend the gesture hit test area.
  • Adjust the Android-style drag handle.
  • Fix the issue of "unable to drag the handle from the vertical direction."
android_gesture.mp4

@LucasXu0 LucasXu0 force-pushed the improve_android_gesture branch from b59662c to 967bac6 Compare January 5, 2024 05:26
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 251 lines in your changes are missing coverage. Please review.

Comparison is base (de94a58) 78.13% compared to head (967bac6) 77.16%.
Report is 1 commits behind head on main.

Files Patch % Lines
.../src/render/selection/mobile_selection_handle.dart 9.40% 183 Missing ⚠️
...nt/service/selection/mobile_selection_service.dart 25.33% 56 Missing ⚠️
...t/service/selection/desktop_selection_service.dart 0.00% 6 Missing ⚠️
...or_component/service/selection_service_widget.dart 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
- Coverage   78.13%   77.16%   -0.97%     
==========================================
  Files         291      291              
  Lines       12763    12931     +168     
==========================================
+ Hits         9972     9978       +6     
- Misses       2791     2953     +162     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 07afd7a into AppFlowy-IO:main Jan 5, 2024
9 of 11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Jan 8, 2024
* main:
  chore: bump version 2.2.0 (AppFlowy-IO#650)
  fix: android 14 issues (AppFlowy-IO#649)
  feat: improve ios touch gesture (AppFlowy-IO#648)
  feat: improve android selection gesture (AppFlowy-IO#647)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant