fix: support character deletion while holding down the Shift key. #659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is related to the bug in AppFlowy-IO/AppFlowy:
I've addressed the reported issue with the following changes:
Issue:
When the shift key is held down, deleting a character or selection by pressing backspace is not functioning as expected.
Solution:
I've implemented a fix by assigning the same Backspace handler in
backspace_command.dart
to another command shortcut event handler nameddeleteLeftCharacterCommand
which is responsible for handlingshift+backspace
shortcut event. This adjustment ensures that the deletion functionality works seamlessly, resolving the reported bug.Repository Context:
Although the issue is posted in another related repository AppFlowy-IO/AppFlowy, the code files relevant to this bug are present in this repository. Therefore, I've created this PR here.
Additional Changes:
I've also included the required test files to ensure the reliability of this fix.