Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Optimize Enter operation #673

Merged

Conversation

q200892907
Copy link
Contributor

@q200892907 q200892907 commented Jan 13, 2024

Modify the operation of the Enter key for list type blocks. If it is empty, perform the Shift+Tab operation until it returns to no format.

2024-01-13.10.11.02.mov

@LucasXu0
Copy link
Collaborator

@q200892907 Please update the tests.

@q200892907
Copy link
Contributor Author

q200892907 commented Jan 14, 2024

@q200892907 Please update the tests.

add tests @LucasXu0

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Jan 14, 2024

@q200892907 Actually, what I meant was fixing the existing tests that also failed.

00:31 +519 -2: /Users/lucas.xu/Desktop/development/appflowy-editor/test/new/service/shortcuts/command_shortcut_events/enter_without_shift_in_text_node_handler_test.dart: enter_without_shift_in_text_node_handler.dart Presses enter key in bulleted list indented [E]
  Test failed. See exception logs above.
  The test description was: Presses enter key in bulleted list indented


To run this test again: /Users/lucas.xu/Desktop/flutter/bin/cache/dart-sdk/bin/dart test /Users/lucas.xu/Desktop/development/appflowy-editor/test/new/service/shortcuts/command_shortcut_events/enter_without_shift_in_text_node_handler_test.dart -p vm --plain-name 'enter_without_shift_in_text_node_handler.dart Presses enter key in bulleted list indented'
00:50 +777 -2: Some tests failed.

@q200892907
Copy link
Contributor Author

@LucasXu0 update test

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d373be) 76.47% compared to head (c64dfb4) 76.49%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
+ Coverage   76.47%   76.49%   +0.02%     
==========================================
  Files         295      295              
  Lines       13046    13076      +30     
==========================================
+ Hits         9977    10003      +26     
- Misses       3069     3073       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit b7c381e into AppFlowy-IO:main Jan 15, 2024
10 of 11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Jan 17, 2024
* main:
  fix: unable to use slide gesture to close keyboard (AppFlowy-IO#676)
  feat: optimize Enter operation (AppFlowy-IO#673)
  feat: parse nested numbered list (AppFlowy-IO#674)
  fix: headingBlockComponentBuilder doesn't use placeholderTextStyle (AppFlowy-IO#677)
  fix: the magnifier doesn't disappear when the selection is collapsed (AppFlowy-IO#675)
@q200892907 q200892907 deleted the feat-insert_newline_in_type_command branch January 17, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants