-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add support for breakline and divider #690
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@penkzhou Please include the tests. |
@LucasXu0 just add the test for |
@penkzhou There're two tests failed. |
@LucasXu0 has fixed the failed tests. |
penkzhou
changed the title
fix: add support for breakline
fix: add support for breakline and divider
Jan 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #690 +/- ##
==========================================
- Coverage 76.46% 76.36% -0.11%
==========================================
Files 295 296 +1
Lines 13309 13319 +10
==========================================
- Hits 10177 10171 -6
- Misses 3132 3148 +16 ☔ View full report in Codecov by Sentry. |
q200892907
added a commit
to q200892907/appflowy-editor
that referenced
this pull request
Jan 31, 2024
* main: chore: bump version 2.3.1 (AppFlowy-IO#697) feat: add contentInsertionConfiguration to editor and text input service (AppFlowy-IO#691) fix: add support for breakline and divider (AppFlowy-IO#690) chore: translate commands (AppFlowy-IO#687)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
documentToHTML
will transfer the empty line into emptyp
tag. This will make when render the markdown content into html ignore the emptyp
tag which will ignore all the break lines.divider
tag. it will transferdivider
intohr
tag.