fix: fix checkbox not work as expected in html module. #700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, let me describe how the bug was discovered. I was using this lib to export Markdown to PDF. The library first renders the Markdown in an editor on the page by calling the
markdownToDocument
method. It then converts the rendered document to HTML code via thedocumentToHtml
method. Finally, it exports the generated HTML into a PDF file.To visualize the steps, here are some screenshots:
bug cause
according the MDN docs, checkbox should write like this:
checked checkbox
<input type="checkbox" id="scales" name="scales" checked /> <label for="scales">Scales</label>
non check checkbox(without
checked
attribute)<input type="checkbox" id="scales" name="scales" /> <label for="scales">Scales</label>
how to fix it
change the code in the
todo_list_node_parser.dart
file. main change include following points:input
tag to keep checkbox in the first of the line.checkbox
'schecked
attribute.