Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Image node extension and toolbar icon size as well as width height can be changed #75

Closed
wants to merge 0 commits into from

Conversation

alihassan143
Copy link
Contributor

@alihassan143 alihassan143 commented Apr 14, 2023

fix #76
if align attribute not present

@alihassan143 alihassan143 changed the title Image node extension and toolbar icon size as well as with height can be changed feat: Image node extension and toolbar icon size as well as with height can be changed Apr 14, 2023
@alihassan143 alihassan143 changed the title feat: Image node extension and toolbar icon size as well as with height can be changed feat: Image node extension and toolbar icon size as well as width height can be changed Apr 14, 2023
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #75 (d8a070c) into main (fd13ad4) will increase coverage by 0.01%.
The diff coverage is 81.86%.

❗ Current head d8a070c differs from pull request most recent head 9f80d9a. Consider uploading reports for the commit 9f80d9a to get more accurate results

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   86.77%   86.79%   +0.01%     
==========================================
  Files         124      125       +1     
  Lines        7185     7353     +168     
==========================================
+ Hits         6235     6382     +147     
- Misses        950      971      +21     
Impacted Files Coverage Δ
lib/src/render/action_menu/action_menu_item.dart 100.00% <ø> (ø)
lib/src/render/image/image_upload_widget.dart 93.54% <ø> (-0.74%) ⬇️
lib/src/render/rich_text/checkbox_text.dart 98.00% <ø> (ø)
...nternal_key_event_handlers/number_list_helper.dart 100.00% <ø> (ø)
lib/src/service/selection_service.dart 84.19% <ø> (ø)
lib/src/render/style/plugin_styles.dart 88.33% <20.00%> (-1.50%) ⬇️
...internal_key_event_handlers/backspace_handler.dart 86.40% <20.00%> (-1.41%) ⬇️
lib/src/flutter/overlay.dart 56.92% <27.27%> (-0.99%) ⬇️
lib/src/service/input_service.dart 60.48% <33.33%> (-0.50%) ⬇️
...nternal_key_event_handlers/copy_paste_handler.dart 18.90% <33.33%> (-0.10%) ⬇️
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Xazin
Copy link
Contributor

Xazin commented Apr 14, 2023

Commits don't conform to commit messages lint.

See here: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

It probably won't matter when the PR is merged (because it will be squashed), but it's good to know for the future. If you want to learn how to fix the commit history, you can see my comment here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Image node render image first time on coming back to editor again start showing error again
2 participants