Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: document getting first or last node exception #885

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix: document getting first or last node exception #885

merged 1 commit into from
Sep 11, 2024

Conversation

Linij
Copy link
Contributor

@Linij Linij commented Sep 10, 2024

fix issue #884

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.49%. Comparing base (cf9943e) to head (09ddbc5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #885   +/-   ##
=======================================
  Coverage   72.49%   72.49%           
=======================================
  Files         317      317           
  Lines       14774    14774           
=======================================
  Hits        10710    10710           
  Misses       4064     4064           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/src/core/document/document.dart Outdated Show resolved Hide resolved
lib/src/core/document/document.dart Outdated Show resolved Hide resolved
@LucasXu0
Copy link
Collaborator

@Linij Thanks for your contribution. Please update your comment.

@Linij Linij changed the title fix: handle null check for first and last nodes in Document.blank() fix: document getting first or last node exception Sep 11, 2024
@Linij
Copy link
Contributor Author

Linij commented Sep 11, 2024

hi,i accept the suggesstion code, and update the commit.

@LucasXu0 LucasXu0 merged commit c3c7005 into AppFlowy-IO:main Sep 11, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants