Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: insert the pasted nodes after current selection if they start with a non-delta node #908

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Oct 1, 2024

closes AppFlowy-IO/AppFlowy#6440

If the pasted content starts with a non-delta block, insert the content below the current selection. Otherwise, keep the original logic.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.04%. Comparing base (c5de9ed) to head (7bdbf94).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ervice/shortcuts/command/copy_paste_extension.dart 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
+ Coverage   71.89%   72.04%   +0.15%     
==========================================
  Files         318      318              
  Lines       14955    14962       +7     
==========================================
+ Hits        10752    10780      +28     
+ Misses       4203     4182      -21     
Flag Coverage Δ
72.04% <81.81%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 3bbdccd into AppFlowy-IO:main Oct 1, 2024
7 checks passed
LucasXu0 added a commit to LucasXu0/appflowy-editor that referenced this pull request Oct 1, 2024
…th a non-delta node (AppFlowy-IO#908)

* fix: insert the pasted nodes after current selection if they start with a non-delta node

* test: add paste multiple nodes test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Pasting in-app json on a line with text can cause corrupt blocks
1 participant