Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not highlight inactive items on empty selection #915

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

Xazin
Copy link
Collaborator

@Xazin Xazin commented Oct 8, 2024

Closes: #1681

This is simply an improvement to the behavior, there is nothing to "apply" formatting options on, so should we even show these options? We can improve that later..

Before:

before-highlight-fix.mp4

After:

after-highlight-fix.mp4

@Xazin Xazin requested a review from LucasXu0 October 8, 2024 15:58
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.06%. Comparing base (8eb1400) to head (b70b616).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #915   +/-   ##
=======================================
  Coverage   72.05%   72.06%           
=======================================
  Files         318      318           
  Lines       14991    14993    +2     
=======================================
+ Hits        10802    10804    +2     
  Misses       4189     4189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

import 'package:flutter/material.dart' hide Overlay, OverlayEntry;

import 'package:appflowy_editor/appflowy_editor.dart';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you use a different formatter than I do. Every time I format the code, these imports will be reverted.

Copy link
Collaborator Author

@Xazin Xazin Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use this extension https://marketplace.visualstudio.com/items?itemName=aziznal.dart-import-sorter for cleaner imports, makes them easier to read in my opinion.

I don't think it matters much that we keep changing them, what I don't understand is why the built-in formatter is so fond of changing it back 😂.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Dart VSCode extension, I think you have a command "Organize imports", can you try using it and see if it produces same result?

@Xazin Xazin merged commit 6130b16 into AppFlowy-IO:main Oct 9, 2024
7 checks passed
@Xazin Xazin deleted the fix/empty-selection-highlight branch October 9, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Editor toolbar glitch
2 participants