Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ctrl+delete does not delete newlines #917

Merged
merged 3 commits into from
Oct 9, 2024
Merged

fix: ctrl+delete does not delete newlines #917

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
455d733
fix: ctrl+delete does not delete newlines
Xazin Oct 8, 2024
83231dc
fix: wrong comment
Xazin Oct 8, 2024
4c79dc0
chore: add collapsed check
Xazin Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions lib/src/editor/editor_component/service/shortcuts/command/remove_word_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import 'package:appflowy_editor/appflowy_editor.dart';
import 'package:flutter/material.dart';

/// Backspace key event.
import 'package:appflowy_editor/appflowy_editor.dart';

/// Delete key event.
///
/// - support
/// - desktop
Expand Down Expand Up @@ -96,8 +97,12 @@ CommandShortcutEventHandler _deleteRightWordCommandHandler = (editorState) {
return KeyEventResult.ignored;
}

if (selection.isCollapsed && selection.start.offset == delta.length) {
return deleteCommand.execute(editorState);
}

// we store the position where the current word ends.
var endOfWord = selection.end.moveHorizontal(
Position? endOfWord = selection.end.moveHorizontal(
editorState,
forward: false,
selectionRange: SelectionRange.word,
Expand Down
Loading