Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assertion error in auto_expand_editor example #991

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

mikefaust-jm
Copy link
Contributor

fixes #974 and makes auto scrolling work when reaching the maxHeight of the container

@CLAassistant
Copy link

CLAassistant commented Dec 13, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.15%. Comparing base (ea1bcd3) to head (ed956e5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #991   +/-   ##
=======================================
  Coverage   72.15%   72.15%           
=======================================
  Files         319      319           
  Lines       15224    15224           
=======================================
  Hits        10985    10985           
  Misses       4239     4239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 4f1473b into AppFlowy-IO:main Dec 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unclear scroll assertion
3 participants