Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make appimagetool use zstd #1273

Closed
wants to merge 4 commits into from
Closed

Make appimagetool use zstd #1273

wants to merge 4 commits into from

Conversation

probonopd
Copy link
Member

@probonopd probonopd commented Jun 25, 2023

In anticipation of using https://github.com/AppImage/type2-runtime and

use zstd as the default compression in appiamgetool.

@probonopd
Copy link
Member Author

probonopd commented Jun 25, 2023

Still getting

Generating squashfs...
/tmp/AppImageKit-build-8aSFXR/install-prefix/usr/bin/../lib/appimagekit/mksquashfs: Compressor "" is not supported!
/tmp/AppImageKit-build-8aSFXR/install-prefix/usr/bin/../lib/appimagekit/mksquashfs: Compressors available:
	gzip (default)
	xz

I guess I need the help of @TheAssassin to get CMake to build mksquashfs with zstd; most likely

https://github.com/AppImage/AppImageKit/blob/probonopd-zstd/cmake/dependencies.cmake

needs to be changed?

@TheAssassin
Copy link
Member

Fixing this PR right now.

@probonopd
Copy link
Member Author

Closing this PR since appimagetool will get its own repository.

@probonopd probonopd closed this Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants