Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .metainfo.xml files #1341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Korne127
Copy link

Previously, appimagetool has expected a .appdata.xml file, although that format has been deprecated and .metainfo.xml should be used for new projects. This Pull Request fixes this issue. It adds support for .metainfo.xml files. With this PR, appimagetool will accept both .metainfo.xml and .appdata.xml files.
This PR also adds a warning when using a .appdata.xml file that the file extension should be changed to .metainfo.xml.

Additionally, the link to the generator hasn't worked anymore. This PR replaces it with a working link to an AppStream generator.

Previously, appimagetool had expected a .appdata.xml file, although that format had been deprecated and .metainfo.xml should be used for new projects.
This has been fixed. Support for .metainfo.xml files has been added. appimagetool now accepts both .metainfo.xml and .appdata.xml files.
A warning has also been added when using a .appdata.xml file that the file extension should be changed to .metainfo.xml.

Additionally, the link to the generator hadn't worked anymore. It has been replaced with a working link to an AppStream generator.
@Korne127
Copy link
Author

Korne127 commented Jul 24, 2024

Related:

Maybe these can be merged and resolved as well? I feel like they have been forgotten.

I also plan to update the documentation (not just about this specifically, but in general, there are some things that I think can be improved to make it easier to understand for people who have never used AppImages before).

@Korne127
Copy link
Author

Hm, i just now searched for other related issues and PRs and realised that #1224 essentially does the same.
I do prefer my approach, warning message and the additional generator fix, so I'll leave this open, but maybe the other PR can still be merged for the other file change?

}

if (appstream_found) {
fprintf (stderr, "AppStream upstream metadata found in usr/share/metainfo/%s\n", *appstream_filename);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stderr is not needed here?

@probonopd
Copy link
Member

probonopd commented Jul 24, 2024

Please use the search function. This has been discussed before. We are not fond of supporting two of these files.

We need to find a way to specify one frozen AppStream spec version, and stay with it. We don't want to work with moving targets.

@Korne127
Copy link
Author

I'm sorry, I originally only found AppImage/appimage.github.io#3067. Because it was merged, I assumed that you want to support .metainfo.xml files.
If you don't want to support them in AppImages, it might make sense to add that to documentation.

@probonopd
Copy link
Member

probonopd commented Jul 24, 2024

Well, sooner or later we will probably have to do the switch, if we stay with AppStream at all. We still are struggling with

or maybe retire it in favor of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants