Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Adding ExternalProject_Add example #652

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

README: Adding ExternalProject_Add example #652

wants to merge 4 commits into from

Conversation

thopiekar
Copy link

@thopiekar thopiekar commented Feb 11, 2018

Added a short description how I added AppImageKit in one of my projects.

@probonopd
Copy link
Member

@TheAssassin as our CMake artist in residence, does this "speak" to you?
(For me, the many variables that CMake seems to use everyone makes it hard to understand what it is doing.)

@TheAssassin
Copy link
Member

Looks quite a bit cryptic to me, too. I'll have a detailed look next week.

@thopiekar thopiekar closed this Feb 11, 2018
@thopiekar thopiekar deleted the thopiekar-ExternalProject_Add branch February 11, 2018 18:48
@thopiekar thopiekar restored the thopiekar-ExternalProject_Add branch February 11, 2018 18:48
@thopiekar thopiekar reopened this Feb 11, 2018
@thopiekar
Copy link
Author

Oops, I thought you merged the PR already. I forgot you have permissions to push into my branches if they are used for PRs 😅

@TheAssassin
Copy link
Member

So, I suppose this is about building appimagetool and using it in your project, rather than using our (relatively new) libappimage? I'll clarify that a bit then in the README.

@thopiekar
Copy link
Author

Ok, feel free to do that. No, I'm not using the libappimage, but I guess it should be easy to prevent CMake to generate Makefiles, which build only libappimage 😉

@luzpaz
Copy link

luzpaz commented Nov 19, 2018

I'm confused on what the PR actually does?

CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX} -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_PREFIX_PATH=${CMAKE_INSTALL_PREFIX} -DBUILD_SHARED_LIBS=ON -DBUILD_TESTING=ON
)

SetProjectDependencies(TARGET AppImageKit DEPENDS glib libfuse cairo OpenSSL patch sed wget)
Copy link
Contributor

@azubieta azubieta Nov 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seems to be a native CMake function. I suppose it's a custom macro.
In order to allow other user to reuse your code snippet you must only use native functions.

@thopiekar
Copy link
Author

thopiekar commented Nov 19, 2018 via email

@TheAssassin
Copy link
Member

This PR has been closed by the original author. No need for reviews or anything.

@TheAssassin TheAssassin changed the base branch from appimagetool/master to master December 23, 2018 14:27
@TheAssassin
Copy link
Member

Unexpected side effect of renaming of master branch. Sorry for the noise. Changing base and reopening.

@TheAssassin TheAssassin reopened this Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants