Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release static binaries only #12

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Release static binaries only #12

merged 1 commit into from
Jul 1, 2023

Conversation

TheAssassin
Copy link
Member

@TheAssassin TheAssassin commented Jun 26, 2023

Fixes #1.

@TheAssassin TheAssassin requested a review from probonopd June 26, 2023 19:48
@TheAssassin
Copy link
Member Author

@probonopd static binaries for libassuan are not available for arm, apparently, but only for x86_64/i686. Could you open another issue, please?

@probonopd
Copy link
Member

Copy link
Member

@probonopd probonopd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but could we also optimize for size here, along the lines of

# Minimize binary size
export CFLAGS="-ffunction-sections -fdata-sections -Os"

for everything?

@TheAssassin
Copy link
Member Author

It won't save any significant amount of space, but comes at the cost of reduced debuggability. I don't see any point in doing so. I'd rather review what we are linking against first.

By the way, I would not recommend stripping any of the binaries either.

@probonopd
Copy link
Member

probonopd commented Jun 27, 2023

Answer by alice upstream regarding the missing ARM builds:

that's because the arm builders are/were offline, but it will be there when they come back

It seems like the ARM builders have been down since ~ a week. Hopefully will be back soon.

Shall we just comment out the ARM builds in the meantime?

@TheAssassin
Copy link
Member Author

We have no pressure, really, do we? I don't mind keeping this open for another week. AppImageKit is still up and running, and nobody's using this repository as of yet.

@TheAssassin
Copy link
Member Author

TheAssassin commented Jul 1, 2023

Just tried, ARM packages for libassuan-static are available now. I'll restart the CI.

Edit: GitHub disagress, at least for AArch64. Let's retry later again.

@probonopd probonopd merged commit 3202510 into main Jul 1, 2023
@TheAssassin
Copy link
Member Author

Please do not unexpectedly merge PRs. I just found a regression.

@TheAssassin
Copy link
Member Author

Note: regression only affects AppImageLauncher and is likely due to the runtime itself, not appimagetool's now-static AppImage. The AppImage works fine without AppImageLauncher. I'll open an issue in the right place once I know what the problem is.

@TheAssassin TheAssassin deleted the static branch July 1, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support building of static libraries on Alpine Linux
2 participants