Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download classic runtime by default #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheAssassin
Copy link
Member

The static runtime is still considered experimental and not nearly as battle-tested as the "classic" variant from AppImageKit.

For users who wish to download the static variant instead, an environment variable was added which changes the new default behavior.

This commit allows me to use this new appimagetool in linuxdeploy-plugin-appimage, which would serve as a field test for the tool itself. I do not want to make people use the static variant until it is fully compatible with everything and the specification changes have been made.

The static runtime is still considered experimental and not nearly as battle-tested as the "classic" variant from AppImageKit.

For users who wish to download the static variant instead, an environment variable was added which changes the new default behavior.
Copy link
Member

@probonopd probonopd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the old runtime opt-in. After all, who does nothing still gets the old runtime from the AppImageKit repo. People who change to this repo do so because they want the static runtime.

Let's change it the other way around - static by default, old by opt-in.
This would be in line with AppImage/AppImageKit#877 (comment) - which got lots of upvotes.

The old runtime is not maintained anymore, not recommended anymore.

@TheAssassin
Copy link
Member Author

Nope. I explained the rationale very well. The vast majority of AppImages is built with regular appimagetool. This tool can't just switch to some experiment without prior notice.

It was you who wanted to have no unnecessary changes before a 1.0 release.

@TheAssassin
Copy link
Member Author

People who change to this repo do so because they want the static runtime.

Show me. This repository has not been advertised anywhere on purpose. At least not by me. Which is in line with what we discussed recently.

@probonopd
Copy link
Member

appimagetool is free to use the old appimagetool or opt out of the static runtime. Although I thought we wanted to get rid of the old dynamically linked runtime asap.

@probonopd
Copy link
Member

Show me.

See the upvotes on AppImage/AppImageKit#877 (comment) - people can't wait to get the static runtime due to Ubuntu not shipping libfuse2 anymore.

@TheAssassin
Copy link
Member Author

The old runtime is not maintained anymore, not recommended anymore.

It is of course still maintained actively, being part of the core AppImage repositories. Just because there are no changes doesn't mean that it is not maintained. Please stop spreading misleading information.

upvotes

are not a representative statistic measure in anyway. Just looking at the download counts proves you wrong.

@TheAssassin TheAssassin dismissed probonopd’s stale review July 16, 2023 22:39

Sudden new requirement not in line with previous discussion.

@probonopd
Copy link
Member

probonopd commented Jul 16, 2023

This PR requires discussion.

@probonopd
Copy link
Member

@TheAssassin have you found a way to update AIL so that this PR is no longer needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants