-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static desktop-file-validate and zsyncmake #47
Conversation
Attempt to fix `autoreconf: command not found`
|
Please merge this. I'm building appimages on alpine and they don't have zsync on their repo. Btw @probonopd I tried to use your static zsyncmake and it isn't working, even though appimagetool says that everything went right with zsyncmake no .zsync file ever gets made. |
@TheAssassin ready for merging? |
This PR falls short of some expectations. You still need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no way for the user to use a newer release or custom binary of desktop-file-validate
. This means that in theory, you need to keep this tool very much up to date to fix potential compatibility problems with newer versions of the specification. Another option is to let a system-wide-installed binary precede the one contained in the AppImage (something that requires a few more lines of code and some additional directory for the $PATH
) or maybe a dedicated environment variable to specify the path exactly (e.g., DESKTOP_FILE_VALIDATE_PATH=/usr/bin/desktop-file-validate
).
@TheAssassin feel free to add a Dependabot in a separate PR. |
Build static
desktop-file-validate
andzsyncmake
similar to what we are already doing formksquashfs
.Closes #9