Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static desktop-file-validate and zsyncmake #47

Merged
merged 19 commits into from
Dec 8, 2024
Merged

Static desktop-file-validate and zsyncmake #47

merged 19 commits into from
Dec 8, 2024

Conversation

probonopd
Copy link
Member

@probonopd probonopd commented May 9, 2024

Build static desktop-file-validate and zsyncmake similar to what we are already doing for mksquashfs.

Closes #9

@probonopd probonopd marked this pull request as draft May 9, 2024 08:19
@probonopd
Copy link
Member Author

$ ./appimagetool-x86_64.AppImage --appimage-extract
$ file squashfs-root/usr/bin/desktop-file-validate
squashfs-root/usr/bin/desktop-file-validate: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, BuildID[sha1]=..., stripped

@probonopd probonopd marked this pull request as ready for review May 9, 2024 08:53
@probonopd probonopd changed the title Add install-static-desktop-file-validate.sh Static desktop-file-validate and zsyncmake May 9, 2024
@Samueru-sama
Copy link
Contributor

Please merge this. I'm building appimages on alpine and they don't have zsync on their repo.

Btw @probonopd I tried to use your static zsyncmake and it isn't working, even though appimagetool says that everything went right with zsyncmake no .zsync file ever gets made.

@probonopd
Copy link
Member Author

@TheAssassin ready for merging?

ci/build-in-docker.sh Outdated Show resolved Hide resolved
@TheAssassin
Copy link
Member

This PR falls short of some expectations. You still need file to be installed on the system. appstream-util is another optional dependency.

Copy link
Member

@TheAssassin TheAssassin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no way for the user to use a newer release or custom binary of desktop-file-validate. This means that in theory, you need to keep this tool very much up to date to fix potential compatibility problems with newer versions of the specification. Another option is to let a system-wide-installed binary precede the one contained in the AppImage (something that requires a few more lines of code and some additional directory for the $PATH) or maybe a dedicated environment variable to specify the path exactly (e.g., DESKTOP_FILE_VALIDATE_PATH=/usr/bin/desktop-file-validate).

@probonopd
Copy link
Member Author

probonopd commented Dec 8, 2024

There is no way for the user to use a newer release or custom binary of desktop-file-validate. This means that in theory, you need to keep this tool very much up to date to fix potential compatibility problems with newer versions of the specification.

@TheAssassin feel free to add a Dependabot in a separate PR.

@probonopd probonopd requested a review from TheAssassin December 8, 2024 17:06
@probonopd probonopd enabled auto-merge (squash) December 8, 2024 17:07
@probonopd probonopd merged commit ad50c02 into main Dec 8, 2024
10 checks passed
@probonopd probonopd deleted the static-tools branch December 8, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundle static versions of desktop-file-validate and zsyncmake
3 participants