Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default block size with zstd compression #65

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Use default block size with zstd compression #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/appimagetool.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,12 +156,13 @@ int sfs_mksquashfs(char *source, char *destination, int offset) {
args[i++] = "16384";
} else if (strcmp(sqfs_comp, "zstd") == 0) {
/*
* > Build with 1MiB block size
* > Using a bigger block size than mksquashfs's default improves read speed and can produce smaller AppImages as well
* -- https://github.com/probonopd/go-appimage/commit/c4a112e32e8c2c02d1d388c8fa45a9222a529af3
* > Build with default 128K block size
* > It used to be 1M but that actually causes much higher startup times.
* > Some testing might be needed to see if there is some other value that actually improves performance.
* -- https://github.com/AppImage/appimagetool/issues/64
*/
args[i++] = "-b";
args[i++] = "1M";
args[i++] = "128K";
TheAssassin marked this conversation as resolved.
Show resolved Hide resolved
}

// check if ignore file exists and use it if possible
Expand Down
Loading