Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward Linux capabilities to child process #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+97 −0
Open

Forward Linux capabilities to child process #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 97 additions & 0 deletions src/runtime/runtime.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ extern int sqfs_opt_proc(void* data, const char* arg, int key, struct fuse_args*
#include <fnmatch.h>
#include <sys/mman.h>
#include <stdint.h>
#include <sys/prctl.h>
#include <linux/capability.h>
#include <sys/syscall.h>

typedef struct {
uint32_t lo;
Expand Down Expand Up @@ -1331,6 +1334,97 @@ char* appimage_hexlify(const char* bytes, const size_t numBytes) {
return hexlified;
}

int appimage_adjust_capabilities()
{
struct __user_cap_header_struct hdr;
struct __user_cap_data_struct data[_LINUX_CAPABILITY_U32S_3];
int res, datacnt;
unsigned long long capeff, capperm, capinh;
pid_t p;

hdr.version = 0;
hdr.pid = 0;
res = syscall(SYS_capget, &hdr, NULL);
if (res)
{
if (errno != EINVAL || hdr.version == 0)
{
fprintf(stderr, "SYS_capget syscall failed with %d\n", errno);
return -1;
}
}
else if (hdr.version == 0)
{
fprintf(stderr, "Failed to query capability version\n");
return -1;
}

//fprintf(stderr, "Linux capability version: %x\n", hdr.version);

switch (hdr.version)
{
case _LINUX_CAPABILITY_VERSION_1:
datacnt = _LINUX_CAPABILITY_U32S_1;
break;
case _LINUX_CAPABILITY_VERSION_2:
datacnt = _LINUX_CAPABILITY_U32S_2;
break;
case _LINUX_CAPABILITY_VERSION_3:
datacnt = _LINUX_CAPABILITY_U32S_3;
break;
default:
fprintf(stderr, "Unknown Linux capability version: %x; forcing version 3\n", hdr.version);
datacnt = _LINUX_CAPABILITY_U32S_3;
hdr.version = _LINUX_CAPABILITY_VERSION_3;
}

res = syscall(SYS_capget, &hdr, &data);
if (res)
{
fprintf(stderr, "Failed to query capabilities; error: %d\n", errno);
return -1;
}

//for (int i = 0; i < datacnt; ++i)
//{
// fprintf(stderr, "Set %d: eff = %08x, perm = %08x, inh = %08x\n", i, data[i].effective, data[i].permitted, data[i].inheritable);
//}

for (int i = 0; i < datacnt; ++i)
{
data[i].inheritable |= data[i].permitted;
}

res = syscall(SYS_capset, &hdr, &data);
if (res)
{
fprintf(stderr, "Failed to set capabilities; error: %d\n", errno);
return -1;
}

/* now we can set up the ambient set */
for (int i = 0; i < datacnt; ++i)
{
for (int j = 0; j < 32; ++j)
{
int capval = i * 32 + j;
int capbit = 1 << j;

if ((data[i].permitted & capbit) && (data[i].inheritable & capbit))
{
res = prctl(PR_CAP_AMBIENT, PR_CAP_AMBIENT_RAISE, capval, 0, 0);
if (res)
{
fprintf(stderr, "Failed to set ambient capability %d; error: %d\n", capval, errno);
return 1;
}
}
}
}

return 0;
}

int main(int argc, char* argv[]) {
char appimage_path[PATH_MAX];
char argv0_path[PATH_MAX];
Expand Down Expand Up @@ -1704,6 +1798,9 @@ int main(int argc, char* argv[]) {
setenv("XDG_CONFIG_HOME", portable_config_dir, 1);
}

/* Ensure that capabilities for the AppImage are applied to the children */
appimage_adjust_capabilities();

/* Original working directory */
char cwd[1024];
if (getcwd(cwd, sizeof(cwd)) != NULL) {
Expand Down
Loading