Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satisfy shellcheck; do not install apt packages from shell script #9

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

probonopd
Copy link
Member

@probonopd probonopd commented Jun 25, 2023

Implement improvements suggested by @TheAssassin

@probonopd probonopd requested a review from TheAssassin June 25, 2023 17:08
As suggested by @TheAssassin; so that the local system is not changed by running the shell scripts
@probonopd probonopd changed the title Satisfy shellcheck in build.sh Satisfy shellcheck; do not install apt packages from shell script Jun 25, 2023
Copy link
Member

@TheAssassin TheAssassin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I'm not convinced of the build system itself (we discussed this today), the changes are fine and an improvement overall.

@probonopd probonopd merged commit 7804775 into main Jun 26, 2023
@probonopd probonopd deleted the shellcheck branch June 26, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants