-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow updating AppImages from AppImageHub.com #178
Conversation
Thanks @azubieta, this would be a great addition. Let's see that we can get it to build.
Triggered a re-run, let's see how it goes. Getting now
What is going on... turns out GitHub removed Ubuntu 16.04 from their default templates because it no longer receives standard support from Canonical: |
caccb94
to
79a0c0f
Compare
Would it be possible to rename "pling" to "OCS" and remove the hardcoded URL from the source to make it more generic? Looking at AppImage/AppImageKit#1152 (comment) the URL is part of the proposed update information string. |
fcbb0ee
to
7554bb9
Compare
The original plan was to support the OCS API but they guys from pling did some modifications to it. Like generating a zsync file for each download. I don't think this would be available in other implementations. I'll update the related issue in the AppImageKit repo. |
Then we need a pling update information type. Still would make the URL not hardcoded, as someone might set up their own pling instance (I guess). |
I'm no sure if hosting a pling instance is something someone could do as the code is not published anywhere. |
This PR has not passed a QA review, and therefore there are multiple issues, for instance there's no clear interface in the new update methods concept (abstract base class, for instance) that could be programmed against, thus the updater implementation needs to know implementation details. Of course, the lack of abstractions is a general problem in AppImageUpdate, my original design is anything but ideal by my current standards. I think an opportunity to fix some of the issues in the code base was missed here, though. I'm reworking parts of the updater anyway to implement a couple new features in libappimageupdate that'll make integration in third-party software easier (which I had wanted to do for a while already, there is a feature wishlist), and in this process I'm going to fix those issues. I already introduced a separate type for the update information (similar I'd highly appreciate waiting for a qualified review, it really helps increase code quality. 10 days is really not a long time. |
No description provided.