appimage_read_file_into_buffer_following_symlinks #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was quite a challenge to get to this point (I had to read into a lot of code, and performed quite some refactoring to make the code more maintainable), but this should do the job. @kbroulik please review/test. |
kbroulik
reviewed
Sep 10, 2018
src/libappimage/type1.c
Outdated
| #ifdef STANDALONE | ||
| fprintf(stderr, "failed to read data into buffer: %s\n", archive_error_string(a)); | ||
| #endif | ||
| return false; |
There was a problem hiding this comment.
Don't you leak the buffer here, given you don't pass it outside for manual free() but you also don't dispose of it in here?
There was a problem hiding this comment.
Good catch, it must be free()d of course.
|
@kbroulik and I tested this code with a lot of AppImages, and it appears to work fine. |
|
Great. Thanks @kbroulik and @TheAssassin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1.