Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode build is not licensed under MIT #82

Closed
fusion809 opened this issue Sep 2, 2016 · 12 comments
Closed

VSCode build is not licensed under MIT #82

fusion809 opened this issue Sep 2, 2016 · 12 comments

Comments

@fusion809
Copy link

Hi,

The VSCode AppImage is not licensed under the MIT License, because it is built from the binary releases provided by Microsoft, which are licensed under a proprietary End-User License Agreement (EULA). If the AppImage was built from VSCode's source code, then it would be licensed under MIT (as its source code is MIT Licensed), but as it is built from Microsoft's binary releases it is governed by the license of these binary releases.

Thanks for your time,
Brenton

@probonopd
Copy link
Member

Hi Brenton,

do you want me to remove the AppImage? I had asked for permission in
microsoft/vscode#10857

Thanks,
Simon

Am Freitag, 2. September 2016 schrieb Brenton Horne :

Hi,

The VSCode AppImage is not licensed under the MIT License, because it is
built from the binary releases provided by Microsoft, which are licensed
under a proprietary End-User License Agreement (EULA). If the AppImage was
built from VSCode's source code, then it would be licensed under MIT (as
its source code is MIT Licensed), but as it is built from Microsoft's
binary releases it is governed by the license of these binary releases.

Thanks for your time,
Brenton


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#82, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACXZuUAXnKnw0DylHCXruw1oHkAsz_r8ks5ql6I2gaJpZM4JzWgF
.

@fusion809
Copy link
Author

Nope, I was hoping you could write a Prefs file that will build an AppImage from VSCode's source code, which would make it MIT-Licensed.

@probonopd
Copy link
Member

probonopd commented Sep 2, 2016

Perhaps @joaomoreno will have a look at it, microsoft/vscode#10857 (comment) - I am happy to help.

@mamal72
Copy link

mamal72 commented Dec 10, 2016

Anything new about this issue? Why we don't have an internal build script.
Building image is one of the most important parts in Electron applications development. I wanted to try AppImages for GNU/Linux but I found #10857 and found this issue. 😕

@fusion809
Copy link
Author

fusion809 commented Dec 10, 2016

Theoretically you could create a repository that builds VSCode from source code (specifically the open-source build) and builds an AppImage from the build artefacts. You need to install the set of build dependencies like Node.js, NPM, gulp, gcc, g++, make, etc. after that you run:

scripts/npm.sh install
node --max_old_space_size=2048 /usr/bin/gulp vscode-linux-x64

from the top-level of VSCode's source code directory (extracted from the source code tarballs of each release). Then copy the contents of the resulting VSCode-linux-x64 directory to your AppImage.

@fusion809
Copy link
Author

I'm giving it an attempt as creating an AppImage from my own Debian package builds is getting annoying. Here is my repository and here is where you can track my builds on Travis CI.

@mamal72
Copy link

mamal72 commented Dec 10, 2016

@fusion809 Thanks for your response. 🙏
So, there's no chance to have build script in the repo and contribute to it and make AppImage builds for Linux, right?
If it's the case, I may go with my own fork of VSCode. This situation really sucks. 😑

@fusion809
Copy link
Author

If you're talking about the upstream repo Microsoft/vscode, well you'll have to ask there if they'd be willing to keep a build script there.

@mamal72
Copy link

mamal72 commented Dec 10, 2016

@fusion809 I see. Thank you so much. 🙏

@fusion809
Copy link
Author

Now my attempt to build an AppImage from Visual Studio Code (OSS) using Travis CI has failed, I reported it at microsoft/vscode#17013.

@fusion809
Copy link
Author

I got it working FTW. If you wanna download it and give it a try see my Code-OSS.AppImage's continuous tag.

@probonopd
Copy link
Member

https://flathub.org/apps/details/com.visualstudio.code has it, with full branding and everything. So I assume we are allowed to do the same in AppImage format?

Using https://github.com/AppImage/pkg2appimage/blob/master/recipes/VSCode.yml it is trivially easy to make an AppImage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants