Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools erroneously allow Java apps without <threadsafe> tag #18

Closed
shatterednirvana opened this issue Nov 2, 2012 · 2 comments
Closed

Tools erroneously allow Java apps without <threadsafe> tag #18

shatterednirvana opened this issue Nov 2, 2012 · 2 comments
Assignees
@shatterednirvana
Labels
Type: Bug
Milestone
1.6.4

Comments

@shatterednirvana
Copy link
Contributor

Originally Java apps had an optional flag called <threadsafe>, but at some point this flag became mandatory. Since we don't check for its existence, users can give us an app without it and we will blindly accept it, causing the app to fail when AppScale tries to start up the Java AppServer.

Need to check for this tag, ensure that it's value is either true or false, and abort if it is not.
@ghost ghost assigned shatterednirvana Nov 2, 2012
shatterednirvana added a commit to shatterednirvana/appscale-tools that referenced this issue Nov 2, 2012
@shatterednirvana
now checking to make sure that java app engine apps have a <threadsaf…
51a7e01 
…e> tag set to true or false, fixing issue AppScale#18
@shatterednirvana
Copy link
Contributor Author

Got a fix for this - sending for QA now.

nlake44 added a commit that referenced this issue Nov 5, 2012
@nlake44
Merge pull request #19 from shatterednirvana/with-threadsafe-java-fix
df6182c 
With threadsafe java fix (fixes issue #18)
@shatterednirvana
Copy link
Contributor Author

Fixed, tested, and released!

@shatterednirvana shatterednirvana mentioned this issue Sep 10, 2012
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shatterednirvana shatterednirvana

Labels
Type: Bug
Projects
None yet
Milestone
1.6.4
Development

No branches or pull requests
1 participant
@shatterednirvana