Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to cve 5.1 schema #196

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Upgrade to cve 5.1 schema #196

merged 4 commits into from
Nov 13, 2024

Conversation

prabhu
Copy link
Contributor

@prabhu prabhu commented Nov 10, 2024 •
edited
Loading

Support for cvss v4 in osv. Also, includes fix for #198

@cerrussell can you check if depscan v6 is alright with this version?

@prabhu
Upgrade to cve 5.1 schema. Support for cvssv4 in osv
357d762 
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu prabhu marked this pull request as ready for review November 10, 2024 20:36
@prabhu prabhu requested a review from cerrussell November 10, 2024 20:48
This was referenced Nov 10, 2024
Merged
Closed
@prabhu prabhu linked an issue Nov 10, 2024 that may be closed by this pull request
[v6.1] CVE schema 5.1 support #138
Closed
@prabhu
Workaround npm bug with inconsistent severity and score
eec0a2b 
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu prabhu mentioned this pull request Nov 10, 2024
Merged
@prabhu
Update readme
116686e 
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@cerrussell
Copy link
Member

@prabhu Sure thing.

@prabhu
Copy link
Contributor Author

prabhu commented Nov 11, 2024

Wondering if there is a way to upgrade all cvss 3.1 to cvss 4 format.

cerrussell
cerrussell reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@cerrussell cerrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern with this is around CSAF compatibility. The latest version of the CSAF spec is 2.0 and it only supports cvss v3.0 and cvss v3.1. If I'm understanding things correctly, this PR will make cvss v4 the default and no scoring will be able to be included for CSAF.

@prabhu
Retain both cvss4 and 3.1
003ee53 
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu
Copy link
Contributor Author

prabhu commented Nov 12, 2024

@cerrussell can you review the latest?

@cerrussell
Copy link
Member

@prabhu Testing it now...

@cerrussell cerrussell self-requested a review November 12, 2024 18:21
cerrussell
cerrussell approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@cerrussell cerrussell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this will work fine for depscan now - just need to make a couple tweaks on that side. We had changed it so CSAF would use the VDR for generation and the VDR will still only be storing one rating and preferring v4.

@prabhu
Copy link
Contributor Author

prabhu commented Nov 12, 2024

@cerrussell This is how I had improved v5 branch to refer to the vector string - https://github.com/owasp-dep-scan/dep-scan/pull/365/files

@cerrussell
Copy link
Member

@prabhu I see... that change breaks CSAF, though, because it's not set up to iterate through a list of ratings as before, there was only ever one in the list.

@prabhu
Copy link
Contributor Author

prabhu commented Nov 13, 2024

Oh dear. Could you propose a PR for v5 branch as well?

@prabhu prabhu merged commit 7d1b603 into master Nov 13, 2024
16 checks passed
@prabhu prabhu deleted the feature/cvss4 branch November 13, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cerrussell cerrussell cerrussell approved these changes

Assignees
No one assigned
Labels
sponsored
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v6.1] CVE schema 5.1 support
2 participants
@prabhu @cerrussell