Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JDOM Dependency #11

Closed
benoitx opened this issue Dec 9, 2014 · 2 comments
Closed

Remove JDOM Dependency #11

benoitx opened this issue Dec 9, 2014 · 2 comments
Assignees
@ks-appendium
Labels
enhancement

Comments

@benoitx
Copy link
Contributor

benoitx commented Dec 9, 2014

Remove JDOM Dependency. Try a pure JDK implementation.
@benoitx benoitx closed this as completed in 75e7291 Jul 4, 2018
@martindiphoorn
Copy link
Collaborator

I just noticed that there is an unit test failing.

testInvalidMap(net.sf.flatpack.xml.MapParserTest)  Time elapsed: 0.005 sec
testParseFixedMap(net.sf.flatpack.xml.MapParserTest)  Time elapsed: 0.024 sec
testParseComplexFixedMap(net.sf.flatpack.xml.MapParserTest)  Time elapsed: 0.003 sec  <<< ERROR!
java.lang.NullPointerException
	at java.io.Reader.<init>(Reader.java:78)
	at java.io.InputStreamReader.<init>(InputStreamReader.java:72)
	at net.sf.flatpack.xml.MapParserTest.testParseComplexFixedMap(MapParserTest.java:81)

https://travis-ci.org/Appendium/flatpack/builds/400190069?utm_source=github_status&utm_medium=notification

martindiphoorn added a commit to martindiphoorn/flatpack that referenced this issue Jul 5, 2018
@martindiphoorn
Appendium#11 fix unit test
51d35dd
@martindiphoorn
Copy link
Collaborator

PR: #38

benoitx added a commit that referenced this issue Jul 6, 2018
@benoitx
Merge pull request #38 from martindiphoorn/master
4d24324 
#11 fix unit test
@martindiphoorn martindiphoorn mentioned this issue Jul 11, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ks-appendium ks-appendium

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benoitx @martindiphoorn @ks-appendium