Skip to content
This repository has been archived by the owner on Jul 28, 2020. It is now read-only.

Can you support 'utf8'? #5

Open
zhangkekf opened this issue Mar 14, 2014 · 2 comments
Open

Can you support 'utf8'? #5

zhangkekf opened this issue Mar 14, 2014 · 2 comments

Comments

@zhangkekf
Copy link

I need collect some logs writen in chinese, and that leads to serious questions.

@CatTail
Copy link

CatTail commented Oct 9, 2015

+1

@withnate
Copy link

withnate commented May 24, 2018

@zhangkekf @CatTail
This is a issue in thrift@0.7.0

// thrift/lib/thrift/protocol line 144
TBinaryProtocol.prototype.writeString = function(str) {
  this.writeI32(str.length);
  this.trans.write(str);
}

update to

TBinaryProtocol.prototype.writeString = function(str) {
  let buf = Buffer.from(str)
  this.writeI32(buf.length);
  this.trans.write(buf);
}

then it will be ok and support chinese!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants