-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: remove head error table #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR. I have a few comments. IMO, showing all error values should be optional and controlled using a parameter. Imagine a scenario where a dataset with 1,000,000 rows fails on all of them.
The solution I recommend here is that by default, the behavior stays the same. I can see a few options here to consider - a parameter to set the number of displayed rows and a parameter to show all rows. The latter probably should add some pagination to the table. Also, you will need to adjust the header, as it clearly says that this is only a sample. If you show all errors, than the word "sample" should be removed.
Besides that, two small things:
- Please bump the package version. We follow the X.X.X.900X convention for the development version, so simply change the last X.
- The change is going to belong to the development version, so please follow my suggestion in the changelog.
NEWS.md
Outdated
|
||
# data.validator 0.2.1 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# data.validator 0.2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change belongs to the development version.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 83.65% 83.80% +0.15%
==========================================
Files 5 5
Lines 410 420 +10
==========================================
+ Hits 343 352 +9
- Misses 67 68 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #88
Before submitting a PR please answer:
Changes:
df_error_head_n
variable added to control nrow for error data.frame