CRAN R-devel fix #394
Merged
CRAN R-devel fix #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 5, 2021 15:24
In r-devel `intersect` returns NULL if any of arguments are NULL in contrast to previous R versions in which `intersect` returned a vector of length 0 of a type same as given arguments
- Updated links in DESCRIPTION and vignette - Removed vignettes from .Rbuildignore
mdubel
approved these changes
Nov 5, 2021
|
@jakubnowicki Yes, I can. But I think it's out of scope of this PR and not related to fixes allowing us to submit to CRAN. WDYT about doing it separately? |
|
I'm ok with a separate PR for CI. |
jakubnowicki
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts
warn_unsupported_argsto a R-devel implementation ofbase::intersectR-devel implementation of
intersectreturnsNULLif one of arguments isNULL. Previous implementations ofintersectreturn a vector of length 0, of type same as the non-NULL argument, i.e.intersect("A", NULL)yieldsNULLin R-devel in contrast to prevoiusly returnedcharacter(0)Additionally this PR resolves some of CRAN check notes regarding vignettes and invalid URL's, e.g.
Closes #393
DoD
Major project work has a corresponding task. If there’s no task for what you are doing, create it. Each task needs to be well defined and described.
Change has been tested (manually or with automated tests), everything runs correctly and works as expected. No existing functionality is broken.
No new error or warning messages are introduced.
All interaction with a semantic functions, examples and docs are written from the perspective of the person using or receiving it. They are understandable and helpful to this person.
If the change affects code or repo sctructure, README, documentation and code comments should be updated.All code has been peer-reviewed before merging into any main branch.
All changes have been merged into the main branch we use for development (develop).
Continuous integration checks (linter, unit tests) are configured and passed.
Unit tests added for all new or changed logic.
All task requirements satisfied. The reviewer is responsible to verify each aspect of the task.
Any added or touched code follows our style-guide.