make sure the activation is in state error when input is invalid for paral… #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noha
reviewed
Jun 10, 2024
| @@ -27,9 +27,9 @@ FBParallelActivation >> arguments [ | |||
| { #category : #initialization } | |||
| FBParallelActivation >> initializeValues: anInteger [ | |||
There was a problem hiding this comment.
The method is called initializeValues: Why do we need an ifNil: check here?
There was a problem hiding this comment.
good point, this was highlighting something fishy. I just changed the content of this PR and now the error handling is done directly by the parallel node behavior. This makes more sense to me and everything should be more aligned
noha
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lel activation