Ac 4282 make nested flow suspendable #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 13, 2024 14:51
noha
reviewed
Jun 14, 2024
| FBFlowInstance >> pushExecutor: anExecutor [ | ||
| FBFlowInstance >> pushExecutor: anExecutor [ | ||
|
|
||
| executors add: anExecutor. | ||
| executor := anExecutor | ||
| flowInstance: self; | ||
| suspendedExecutor: executor; |
There was a problem hiding this comment.
why do we still need the suspendedExecutor. Isn't the list of executors not a replacment for that?
There was a problem hiding this comment.
There. is still one executor stepping at a time. When one executor go over all his steps, we still need a mechanism to jump back to the parent executor. This is done by restoring the #suspendedExecutor as current executor of the flow instance
noha
reviewed
Jun 14, 2024
| @@ -8,5 +8,5 @@ Class { | |||
| FBWaitForConditionBehavior >> execute [ | |||
| (self node evaluateConditionWith: activation argument) | |||
| ifTrue: [ activation followAll: self node outgoing ] | |||
| ifFalse: [ activation waitForNode: self ] | |||
There was a problem hiding this comment.
I don't understand that change ;)
noha
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.