passing string by reference

Apra-Labs · Jul 27, 2023 · b590fc8 · b590fc8
1 parent aad7929
commit b590fc8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/base/include/OrderedCacheOfFiles.h b/base/include/OrderedCacheOfFiles.h
@@ -38,9 +38,9 @@ class OrderedCacheOfFiles
  std::string getFileAt(uint64_t timestamp, bool direction);
  bool isTimeStampInFile(std::string& filename, uint64_t timestamp);
  std::string getNextFileAfter(std::string& currentFile, bool direction);
- std::vector<boost::filesystem::path> parseAndSortDateDir(std::string rootDir);
- std::vector<boost::filesystem::path> parseAndSortHourDir(std::string rootDir);
- std::vector<boost::filesystem::path> parseAndSortMp4Files(std::string rootDir);
+ std::vector<boost::filesystem::path> parseAndSortDateDir(std::string& rootDir);
+ std::vector<boost::filesystem::path> parseAndSortHourDir(std::string& rootDir);
+ std::vector<boost::filesystem::path> parseAndSortMp4Files(std::string& rootDir);
  bool parseFiles(uint64_t start_ts, bool direction, bool includeFloorFile = false, bool disableBatchSizeCheck = false, uint64_t skipTS = 0);
  bool getRandomSeekFile(uint64_t ts, bool direction, uint64_t& skipMsecs, std::string& fileName);
  bool getFileFromCache(uint64_t timestamp, bool direction, std::string& fileName);

diff --git a/base/src/OrderedCacheOfFiles.cpp b/base/src/OrderedCacheOfFiles.cpp
@@ -557,7 +557,7 @@ void OrderedCacheOfFiles::insertInVideoCache(Video vid)
  7. If the higher watermark is breached in the videoCache, trigger a cleanup in seperate thread ?
  */
 
-std::vector<boost::filesystem::path> OrderedCacheOfFiles::parseAndSortDateDir(std::string rootDir)
+std::vector<boost::filesystem::path> OrderedCacheOfFiles::parseAndSortDateDir(std::string& rootDir)
 {
  std::vector<boost::filesystem::path> dateDir;
  fs::directory_iterator dateDirIter(rootDir), dateDirEndIter;
@@ -588,7 +588,7 @@ std::vector<boost::filesystem::path> OrderedCacheOfFiles::parseAndSortDateDir(st
  return dateDir;
 }
 
-std::vector<boost::filesystem::path> OrderedCacheOfFiles::parseAndSortHourDir(std::string dateDirPath)
+std::vector<boost::filesystem::path> OrderedCacheOfFiles::parseAndSortHourDir(std::string& dateDirPath)
 {
  std::vector<boost::filesystem::path> hourDir;
 
@@ -612,7 +612,7 @@ std::vector<boost::filesystem::path> OrderedCacheOfFiles::parseAndSortHourDir(st
  return hourDir;
 }
 
-std::vector<boost::filesystem::path> OrderedCacheOfFiles::parseAndSortMp4Files(std::string hourDirPath)
+std::vector<boost::filesystem::path> OrderedCacheOfFiles::parseAndSortMp4Files(std::string& hourDirPath)
 {
  std::vector<boost::filesystem::path> mp4Files;
  fs::directory_iterator mp4FileIter(hourDirPath), mp4FileEndIter;