Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listing Mp4 UT Issues #229

Closed
mraduldubey opened this issue May 18, 2023 · 2 comments
Closed

Listing Mp4 UT Issues #229

mraduldubey opened this issue May 18, 2023 · 2 comments

Comments

@mraduldubey
Copy link
Collaborator

mraduldubey commented May 18, 2023

Describe the bug
Improve the existing UTs for Mp4ReaderSource

To Reproduce
Check mp4readersource_tests.cpp

Expected behavior

  1. Rewrite the UTs using save or compare
  2. Rewrite getSetProps test to actually test something
  3. Add a test for metadata verification (have a video with alternating metadata) - verify in sink
  4. Remove seek tests. All Seek tests should be put in mp4_seek_tests
  5. In UT of mp4reader - not required modules should be present in the pipeline. Currently, extra modules are present
  6. Add some tests for correct metadata of a frame after random seek is done
  7. None of the test should be providing the resolution of the video to the mp4 reader - because it reads resolution on its own

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: All
  • Cuda Version: N/A
  • Architecture: All

Would you like to work on the issue?
@mohammedzakikochargi

@Apra-Labs Apra-Labs deleted a comment from mraduldubey Jun 9, 2023
@mraduldubey
Copy link
Collaborator Author

@mohammedzakikochargi have we addressed all these comments

@mohammedzakikochargi
Copy link
Collaborator

@mohammedzakikochargi have we addressed all these comments

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants