Mp4ReaderSource module - version 2 #268

mohammedzakikochargi · 2023-07-19T10:53:28Z

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description
The new version of Mp4Reader has the following upgrades -
Ordered cache of files integration - jpeg and h264
Seek refactoring - jpeg and h264
Reverse play - jpeg

Alternative(s) considered

Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type

Type Choose one: (Bug fix | Feature | Documentation | Testing | Other)

Screenshots (if applicable)

Checklist

I have read the Contribution Guidelines
I have written Unit Tests
I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach

…verseplayandseek

github-actions · 2023-07-19T11:38:03Z

Test Results Linux

    1 files ±  0     1 suites ±0 10m 20s ⏱️ +56s
271 tests +72 219 ✔️ +69 52 💤 +3 0 ❌ ±0
219 runs +69 167 ✔️ +66 52 💤 +3 0 ❌ ±0

Results for commit 12b655c. ± Comparison against base commit 00c23b9.

This pull request removes 14 and adds 86 tests. Note that renamed tests count towards both.

Mp4ReaderSource_tests ‑ fs_parsing_h264
Mp4ReaderSource_tests ‑ fs_parsing_jpg
Mp4ReaderSource_tests ‑ getSetProps
Mp4ReaderSource_tests ‑ mp4reader_waits_when_no_video_and_reads_whenever_video_is_written
Mp4ReaderSource_tests ‑ mp4v_read_metadata_jpg
Mp4ReaderSource_tests ‑ mp4v_to_h264frames
Mp4ReaderSource_tests ‑ mp4v_to_h264frames_metadata
Mp4ReaderSource_tests ‑ mp4v_to_mono_8_jpg
Mp4ReaderSource_tests ‑ mp4v_to_rgb_24_jpg
Mp4ReaderSource_tests ‑ parse_root_dir_and_find_the_video
…

mp4_dts_strategy ‑ eof_seek_step
mp4_dts_strategy ‑ read_mul_write_one_as_recorded
mp4_dts_strategy ‑ read_mul_write_one_fixed_rate
mp4_getlivevideots_tests ‑ seek_read_loop
mp4_reverse_play ‑ fwd
mp4_reverse_play ‑ seek_dir_change_trig_fresh_parse
mp4_reverse_play ‑ seek_in_revPlay_fail_to_seek_infile_restore
mp4_reverse_play ‑ seek_in_revPlay_prev_hr
mp4_reverse_play ‑ seek_in_revPlayback_prev_day
mp4_reverse_play ‑ seek_in_revPlayback_prev_hr
…

This pull request removes 2 skipped tests and adds 5 skipped tests. Note that renamed tests count towards both.

Mp4ReaderSource_tests ‑ fs_parsing_h264
Mp4ReaderSource_tests ‑ mp4reader_waits_when_no_video_and_reads_whenever_video_is_written

mp4_simul_read_write_tests ‑ basic_chunking
mp4_simul_read_write_tests ‑ basic_parseFS_disabled
mp4_simul_read_write_tests ‑ loop_no_chunking
mp4_simul_read_write_tests ‑ reader_only
mp4_simul_read_write_tests ‑ writer_only

♻️ This comment has been updated with latest results.

github-actions · 2023-07-19T11:47:11Z

Test Results Linux-CudaT

    1 files ±  0     1 suites ±0 10m 22s ⏱️ +55s
362 tests +72 221 ✔️ +69 141 💤 +3 0 ❌ ±0
221 runs +69   80 ✔️ +66 141 💤 +3 0 ❌ ±0

Results for commit 12b655c. ± Comparison against base commit 00c23b9.

This pull request removes 14 and adds 86 tests. Note that renamed tests count towards both.

Mp4ReaderSource_tests ‑ fs_parsing_h264
Mp4ReaderSource_tests ‑ fs_parsing_jpg
Mp4ReaderSource_tests ‑ getSetProps
Mp4ReaderSource_tests ‑ mp4reader_waits_when_no_video_and_reads_whenever_video_is_written
Mp4ReaderSource_tests ‑ mp4v_read_metadata_jpg
Mp4ReaderSource_tests ‑ mp4v_to_h264frames
Mp4ReaderSource_tests ‑ mp4v_to_h264frames_metadata
Mp4ReaderSource_tests ‑ mp4v_to_mono_8_jpg
Mp4ReaderSource_tests ‑ mp4v_to_rgb_24_jpg
Mp4ReaderSource_tests ‑ parse_root_dir_and_find_the_video
…

mp4_dts_strategy ‑ eof_seek_step
mp4_dts_strategy ‑ read_mul_write_one_as_recorded
mp4_dts_strategy ‑ read_mul_write_one_fixed_rate
mp4_getlivevideots_tests ‑ seek_read_loop
mp4_reverse_play ‑ fwd
mp4_reverse_play ‑ seek_dir_change_trig_fresh_parse
mp4_reverse_play ‑ seek_in_revPlay_fail_to_seek_infile_restore
mp4_reverse_play ‑ seek_in_revPlay_prev_hr
mp4_reverse_play ‑ seek_in_revPlayback_prev_day
mp4_reverse_play ‑ seek_in_revPlayback_prev_hr
…

This pull request removes 2 skipped tests and adds 5 skipped tests. Note that renamed tests count towards both.

Mp4ReaderSource_tests ‑ fs_parsing_h264
Mp4ReaderSource_tests ‑ mp4reader_waits_when_no_video_and_reads_whenever_video_is_written

mp4_simul_read_write_tests ‑ basic_chunking
mp4_simul_read_write_tests ‑ basic_parseFS_disabled
mp4_simul_read_write_tests ‑ loop_no_chunking
mp4_simul_read_write_tests ‑ reader_only
mp4_simul_read_write_tests ‑ writer_only

♻️ This comment has been updated with latest results.

…verseplayandseek

github-actions · 2023-07-24T06:30:52Z

Test Results Linux_ARM64

    1 files ±  0     1 suites ±0 10m 59s ⏱️ +56s
385 tests +72 248 ✔️ +69 137 💤 +3 0 ❌ ±0
248 runs +69 111 ✔️ +66 137 💤 +3 0 ❌ ±0

Results for commit 12b655c. ± Comparison against base commit 00c23b9.

This pull request removes 14 and adds 86 tests. Note that renamed tests count towards both.

Mp4ReaderSource_tests ‑ fs_parsing_h264
Mp4ReaderSource_tests ‑ fs_parsing_jpg
Mp4ReaderSource_tests ‑ getSetProps
Mp4ReaderSource_tests ‑ mp4reader_waits_when_no_video_and_reads_whenever_video_is_written
Mp4ReaderSource_tests ‑ mp4v_read_metadata_jpg
Mp4ReaderSource_tests ‑ mp4v_to_h264frames
Mp4ReaderSource_tests ‑ mp4v_to_h264frames_metadata
Mp4ReaderSource_tests ‑ mp4v_to_mono_8_jpg
Mp4ReaderSource_tests ‑ mp4v_to_rgb_24_jpg
Mp4ReaderSource_tests ‑ parse_root_dir_and_find_the_video
…

mp4_dts_strategy ‑ eof_seek_step
mp4_dts_strategy ‑ read_mul_write_one_as_recorded
mp4_dts_strategy ‑ read_mul_write_one_fixed_rate
mp4_getlivevideots_tests ‑ seek_read_loop
mp4_reverse_play ‑ fwd
mp4_reverse_play ‑ seek_dir_change_trig_fresh_parse
mp4_reverse_play ‑ seek_in_revPlay_fail_to_seek_infile_restore
mp4_reverse_play ‑ seek_in_revPlay_prev_hr
mp4_reverse_play ‑ seek_in_revPlayback_prev_day
mp4_reverse_play ‑ seek_in_revPlayback_prev_hr
…

This pull request removes 2 skipped tests and adds 5 skipped tests. Note that renamed tests count towards both.

Mp4ReaderSource_tests ‑ fs_parsing_h264
Mp4ReaderSource_tests ‑ mp4reader_waits_when_no_video_and_reads_whenever_video_is_written

mp4_simul_read_write_tests ‑ basic_chunking
mp4_simul_read_write_tests ‑ basic_parseFS_disabled
mp4_simul_read_write_tests ‑ loop_no_chunking
mp4_simul_read_write_tests ‑ reader_only
mp4_simul_read_write_tests ‑ writer_only

♻️ This comment has been updated with latest results.

github-actions · 2023-07-24T10:30:17Z

Test Results Windows-cuda

    1 files ±  0     1 suites ±0 12m 18s ⏱️ +57s
358 tests +72 280 ✔️ +69 78 💤 +3 0 ❌ ±0
280 runs +69 202 ✔️ +66 78 💤 +3 0 ❌ ±0

Results for commit 12b655c. ± Comparison against base commit 00c23b9.

This pull request removes 14 and adds 86 tests. Note that renamed tests count towards both.

Mp4ReaderSource_tests ‑ fs_parsing_h264
Mp4ReaderSource_tests ‑ fs_parsing_jpg
Mp4ReaderSource_tests ‑ getSetProps
Mp4ReaderSource_tests ‑ mp4reader_waits_when_no_video_and_reads_whenever_video_is_written
Mp4ReaderSource_tests ‑ mp4v_read_metadata_jpg
Mp4ReaderSource_tests ‑ mp4v_to_h264frames
Mp4ReaderSource_tests ‑ mp4v_to_h264frames_metadata
Mp4ReaderSource_tests ‑ mp4v_to_mono_8_jpg
Mp4ReaderSource_tests ‑ mp4v_to_rgb_24_jpg
Mp4ReaderSource_tests ‑ parse_root_dir_and_find_the_video
…

mp4_dts_strategy ‑ eof_seek_step
mp4_dts_strategy ‑ read_mul_write_one_as_recorded
mp4_dts_strategy ‑ read_mul_write_one_fixed_rate
mp4_getlivevideots_tests ‑ seek_read_loop
mp4_reverse_play ‑ fwd
mp4_reverse_play ‑ seek_dir_change_trig_fresh_parse
mp4_reverse_play ‑ seek_in_revPlay_fail_to_seek_infile_restore
mp4_reverse_play ‑ seek_in_revPlay_prev_hr
mp4_reverse_play ‑ seek_in_revPlayback_prev_day
mp4_reverse_play ‑ seek_in_revPlayback_prev_hr
…

This pull request removes 2 skipped tests and adds 5 skipped tests. Note that renamed tests count towards both.

Mp4ReaderSource_tests ‑ fs_parsing_h264
Mp4ReaderSource_tests ‑ mp4reader_waits_when_no_video_and_reads_whenever_video_is_written

mp4_simul_read_write_tests ‑ basic_chunking
mp4_simul_read_write_tests ‑ basic_parseFS_disabled
mp4_simul_read_write_tests ‑ loop_no_chunking
mp4_simul_read_write_tests ‑ reader_only
mp4_simul_read_write_tests ‑ writer_only

♻️ This comment has been updated with latest results.

github-actions · 2023-07-24T13:30:38Z

Test Results Win-nocuda

    1 files ±  0     1 suites ±0 10m 39s ⏱️ + 1m 1s
267 tests +72 219 ✔️ +69 48 💤 +3 0 ❌ ±0
219 runs +69 171 ✔️ +66 48 💤 +3 0 ❌ ±0

Results for commit 12b655c. ± Comparison against base commit 00c23b9.

This pull request removes 14 and adds 86 tests. Note that renamed tests count towards both.

Mp4ReaderSource_tests ‑ fs_parsing_h264
Mp4ReaderSource_tests ‑ fs_parsing_jpg
Mp4ReaderSource_tests ‑ getSetProps
Mp4ReaderSource_tests ‑ mp4reader_waits_when_no_video_and_reads_whenever_video_is_written
Mp4ReaderSource_tests ‑ mp4v_read_metadata_jpg
Mp4ReaderSource_tests ‑ mp4v_to_h264frames
Mp4ReaderSource_tests ‑ mp4v_to_h264frames_metadata
Mp4ReaderSource_tests ‑ mp4v_to_mono_8_jpg
Mp4ReaderSource_tests ‑ mp4v_to_rgb_24_jpg
Mp4ReaderSource_tests ‑ parse_root_dir_and_find_the_video
…

mp4_dts_strategy ‑ eof_seek_step
mp4_dts_strategy ‑ read_mul_write_one_as_recorded
mp4_dts_strategy ‑ read_mul_write_one_fixed_rate
mp4_getlivevideots_tests ‑ seek_read_loop
mp4_reverse_play ‑ fwd
mp4_reverse_play ‑ seek_dir_change_trig_fresh_parse
mp4_reverse_play ‑ seek_in_revPlay_fail_to_seek_infile_restore
mp4_reverse_play ‑ seek_in_revPlay_prev_hr
mp4_reverse_play ‑ seek_in_revPlayback_prev_day
mp4_reverse_play ‑ seek_in_revPlayback_prev_hr
…

This pull request removes 2 skipped tests and adds 5 skipped tests. Note that renamed tests count towards both.

Mp4ReaderSource_tests ‑ fs_parsing_h264
Mp4ReaderSource_tests ‑ mp4reader_waits_when_no_video_and_reads_whenever_video_is_written

mp4_simul_read_write_tests ‑ basic_chunking
mp4_simul_read_write_tests ‑ basic_parseFS_disabled
mp4_simul_read_write_tests ‑ loop_no_chunking
mp4_simul_read_write_tests ‑ reader_only
mp4_simul_read_write_tests ‑ writer_only

♻️ This comment has been updated with latest results.

base/src/OrderedCacheOfFiles.cpp

1. Added tests for mp4_getLiveVideoTs, mp4_dts_strategy, mp4_simul_read_write

mraduldubey

Recheck all the files & address comments

base/include/OrderedCacheOfFiles.h

base/include/Command.h

mohammedzakikochargi added 11 commits June 2, 2023 17:37

reverseplay and seek

6d017cf

Code refactoring - All test passing

9884082

prepend spsPPS and refactorted tests

d467422

removed ramdom seek old function

bc0e71f

updated video file path

5f93675

getSetProps working - tests added

e3088f2

Merge branch 'main' of https://github.com/Apra-Labs/ApraPipes into re…

e4b0f1f

…verseplayandseek

getsetProps changes and code refactoring

ac45750

Video data

e7950bb

Merge branch 'main' of https://github.com/Apra-Labs/ApraPipes into re…

9672afe

…verseplayandseek

Deeleted Mp4ReaderSourceUtils files and small bug fix

f67ffdc

mohammedzakikochargi added 4 commits July 19, 2023 17:32

Updated video file paths in tests

d486301

file parsing code updated

4b6bec6

Merge branch 'main' of https://github.com/Apra-Labs/ApraPipes into re…

5e94a34

…verseplayandseek

Added semicolon

784203d

Updated Mp4Reader arguments

d7988db

mraduldubey requested changes Jul 24, 2023

View reviewed changes

base/src/OrderedCacheOfFiles.cpp Outdated Show resolved Hide resolved

base/src/OrderedCacheOfFiles.cpp Outdated Show resolved Hide resolved

base/src/OrderedCacheOfFiles.cpp Outdated Show resolved Hide resolved

mohammedzakikochargi added 2 commits July 26, 2023 17:43

1. getSetProps - working all the tests passong.

10aae1d

1. Added tests for mp4_getLiveVideoTs, mp4_dts_strategy, mp4_simul_read_write

Added a create dir check

aad7929

mraduldubey requested changes Jul 27, 2023

View reviewed changes

base/include/OrderedCacheOfFiles.h Outdated Show resolved Hide resolved

base/include/Command.h Outdated Show resolved Hide resolved

mohammedzakikochargi added 2 commits July 27, 2023 20:50

passing string by reference

b590fc8

addressed PR errors

12b655c

mraduldubey approved these changes Jul 28, 2023

View reviewed changes

kumaakh merged commit c2f230e into main Jul 28, 2023
17 of 19 checks passed

kumaakh deleted the reverseplayandseek branch July 28, 2023 12:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mp4ReaderSource module - version 2 #268

Mp4ReaderSource module - version 2 #268

mohammedzakikochargi commented Jul 19, 2023 •

edited

Loading

github-actions bot commented Jul 19, 2023 •

edited

Loading

github-actions bot commented Jul 19, 2023 •

edited

Loading

github-actions bot commented Jul 24, 2023 •

edited

Loading

github-actions bot commented Jul 24, 2023 •

edited

Loading

github-actions bot commented Jul 24, 2023 •

edited

Loading

mraduldubey left a comment

Mp4ReaderSource module - version 2 #268

Mp4ReaderSource module - version 2 #268

Conversation

mohammedzakikochargi commented Jul 19, 2023 • edited Loading

github-actions bot commented Jul 19, 2023 • edited Loading

Test Results Linux

github-actions bot commented Jul 19, 2023 • edited Loading

Test Results Linux-CudaT

github-actions bot commented Jul 24, 2023 • edited Loading

Test Results Linux_ARM64

github-actions bot commented Jul 24, 2023 • edited Loading

Test Results Windows-cuda

github-actions bot commented Jul 24, 2023 • edited Loading

Test Results Win-nocuda

mraduldubey left a comment

Choose a reason for hiding this comment

mohammedzakikochargi commented Jul 19, 2023 •

edited

Loading

github-actions bot commented Jul 19, 2023 •

edited

Loading

github-actions bot commented Jul 19, 2023 •

edited

Loading

github-actions bot commented Jul 24, 2023 •

edited

Loading

github-actions bot commented Jul 24, 2023 •

edited

Loading

github-actions bot commented Jul 24, 2023 •

edited

Loading