-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated NvTransform to do scale, crop and color transform #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need tests which run during build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need tests which show if feature works... there are other smaller comments as well
Yeah Akhil, I will work on that
…On Thu, Nov 10, 2022 at 6:07 PM Akhil Kumar ***@***.***> wrote:
***@***.**** requested changes on this pull request.
need tests which show if feature works... there are other smaller comments
as well
—
Reply to this email directly, view it on GitHub
<#176 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVAQDXMWXJYJ4MZ5GOTS6ZLWHTUCDANCNFSM6AAAAAARXDN7U4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
8f1dad1
to
9a931e6
Compare
Hi Akhil, |
Ability to pass filter as props
9a931e6
to
e57f1f4
Compare
As per Yash, he has discussed this with Akhil & we need a separate module to address the review comments.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #175
Checklist