Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated NvTransform to do scale, crop and color transform #176

Merged
merged 6 commits into from
Jul 19, 2023

Conversation

yashrajsapra
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #175
Checklist

  • I have read the Contribution Guidelines
  • I have written Unit Tests
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Test Results Linux-CudaT

    1 files  ±0      1 suites  ±0   9m 25s ⏱️ -1s
290 tests ±0  152 ✔️ ±0  138 💤 ±0  0 ±0 
152 runs  ±0    14 ✔️ ±0  138 💤 ±0  0 ±0 

Results for commit dbba028. ± Comparison against base commit 3aaa81c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Test Results Win-nocuda

    1 files      1 suites   9m 39s ⏱️
195 tests 150 ✔️ 45 💤 0
150 runs  105 ✔️ 45 💤 0

Results for commit dbba028.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Test Results Linux_ARM64

    1 files  ±0      1 suites  ±0   10m 1s ⏱️ ±0s
310 tests +2  179 ✔️ ±0  131 💤 +2  0 ±0 
179 runs  ±0    48 ✔️  - 2  131 💤 +2  0 ±0 

Results for commit dbba028. ± Comparison against base commit 3aaa81c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Test Results Linux

    1 files  ±0      1 suites  ±0   9m 24s ⏱️ ±0s
199 tests ±0  150 ✔️ ±0  49 💤 ±0  0 ±0 
150 runs  ±0  101 ✔️ ±0  49 💤 ±0  0 ±0 

Results for commit dbba028. ± Comparison against base commit 3aaa81c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Test Results WSL

    1 files  ±0      1 suites  ±0   13m 45s ⏱️ ±0s
226 tests ±0  162 ✔️ ±0  64 💤 ±0  0 ±0 
162 runs  ±0    98 ✔️ ±0  64 💤 ±0  0 ±0 

Results for commit 8f1dad1. ± Comparison against base commit f8d8568.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@kumaakh kumaakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need tests which run during build.

base/test/nvtransform_tests.cpp Show resolved Hide resolved
Copy link
Collaborator

@kumaakh kumaakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need tests which show if feature works... there are other smaller comments as well

@yashrajsapra
Copy link
Collaborator Author

yashrajsapra commented Nov 10, 2022 via email

@yashrajsapra
Copy link
Collaborator Author

need tests which show if feature works... there are other smaller comments as well

Hi Akhil,
Need to push a new module for doing a memory conversion from host to dma

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Test Results Windows-cuda

    1 files  ±0      1 suites  ±0   11m 21s ⏱️ ±0s
286 tests ±0  211 ✔️ ±0  75 💤 ±0  0 ±0 
211 runs  ±0  136 ✔️ ±0  75 💤 ±0  0 ±0 

Results for commit dbba028. ± Comparison against base commit 3aaa81c.

♻️ This comment has been updated with latest results.

@mraduldubey mraduldubey dismissed kumaakh’s stale review July 18, 2023 07:50

As per Yash, he has discussed this with Akhil & we need a separate module to address the review comments.

@mraduldubey mraduldubey merged commit 7aa90fe into main Jul 19, 2023
19 of 20 checks passed
@mraduldubey mraduldubey deleted the nvtransformchange branch July 19, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have Crop , Scale and Color Transform in Single NvTransform Module
3 participants