Health & Error Callback Implementation , Improved Abs Control Module #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> Added Health Callback strategy
…ame checks for control modules
…den for custom behaviour in some modules
…praPipes into control_module_fixes
…CallbackImpl Improved Abs Control Module
mraduldubey
requested changes
Jul 30, 2024
Test Results Linux-CudaT 1 files ±0 1 suites ±0 11m 53s ⏱️ -1s For more details on these failures, see this check. Results for commit 11b71c8. ± Comparison against base commit 320408d. ♻️ This comment has been updated with latest results. |
Test Results Linux 1 files ±0 1 suites ±0 10m 9s ⏱️ ±0s For more details on these failures, see this check. Results for commit 11b71c8. ± Comparison against base commit 320408d. ♻️ This comment has been updated with latest results. |
mraduldubey
requested changes
Jul 30, 2024
-> Added Register Error callback -> Sending Error Callback when frame is not there to render
…Pipes into yash/CallbackImpl Added changes from main
… Frequency configurable
mraduldubey
requested changes
Aug 5, 2024
mraduldubey
approved these changes
Aug 7, 2024
Vinayak-YB
pushed a commit
that referenced
this pull request
Aug 7, 2024
…377) * Added Error & Health Status Objects * Added Error & Health Callbacks * Removed unwanted Header Declarartion * Added Health & Error Callback Listener * Fixed Build Issue * -> Added Virtual Function to register error callback -> Added Health Callback strategy * Added Error & Health Callback in ImageEncoder Module * control module changes wip * 1. defined Control module type at framework level 2. enforced data frame checks for control modules * added a virtual method to add control module so that it can be overriden for custom behaviour in some modules * resolved conflict * Fixed Build Issue * Fixed Linking Error * Fixed Typo * revert the multiple pipelines with control module idea * Do not allow roles to be updated once registered * Added COndition to check for input and output pins * Updated handleError and Callback as a virtual function * Added handle Error & Healthback method in Simple Control Module * Removed Dummy Error Callbacks from ImageEncoder Module * USing Simple Control Module in ImageEncoder Tests * Fixed Indentation and typo * Renamed Error, Health and Callback class * Code Cleanup * Fixed warning * Using Updated Health & Error Object class * -> Fixed Formatting -> Added Register Error callback -> Sending Error Callback when frame is not there to render * Renamed Health & ErrorCallback function * Updated GtkGL to use updated APErrorCallback method * Update Module.h * Added Generic Implementation of Error Callback * Formatted APErrorObject class * Updated GtkGLRenderer to Use Generic Error Callbacks, Added Test for same * Removed Unwanted errors * Added healthUpdateIntervalInSec in ModuleProps, To make HealtCallback Frequency configurable * Added Defination of getCurrentTimestamp --------- Co-authored-by: mradul <mradul@apra.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Description
-> Added Health & Error Callbacks
-> Improved Abs Control Module
-> Added Simple Control Module
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Type Choose one: (Bug fix | Feature | Documentation | Testing | Other)
Screenshots (if applicable)
Checklist