enable Python bindings for Windows and macOS #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-rauch
force-pushed
the
test_shared_off
branch
5 times, most recently
from
e4f417b to
5724814
Compare
christian-rauch
force-pushed
the
test_shared_off
branch
from
5724814 to
659ef85
Compare
christian-rauch
changed the title
christian-rauch
force-pushed
the
test_shared_off
branch
from
659ef85 to
95a6fd4
Compare
christian-rauch
force-pushed
the
test_shared_off
branch
from
95a6fd4 to
68ab7e3
Compare
|
@mkrogius @wxmerkt In order to make the Python bindings usable for binary distributed packages and other OSes, the "breaking change" in this PR is the install location for the Python module. I assume you are ok with this, as the new install location is the proper path determined from the CMake install path. |
|
For sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FindPythonLibsmodule has been deprecated since CMake 3.12. The newerFindPythonprovides a better and more portable way to build Python modules without the need for a dedicated script to determine the system configuration. This allows us now to build the Python bindings on Windows and macOS. This PR also changes the install path for the resulting Python module from the "user site" to something determined by the given CMake install path. This allows us to properly install the Python bindings when distributing binary packages.Addresses #267 (comment).