Trim Reblogs: always show trim button

[marcustyphoon]

Seeing a lot of user reports that Trim Reblogs is broken and I would really like to know if it's a button add failure or a misunderstanding about which posts should be trimmable. Hence:

Description

As described in the linked issue, this disables the trim button on editable but untrimmable posts, rather than not adding it at all.

This uses the native dom disabled attribute on the button element and moves the event handlers on control buttons to the button element itself.

Resolves #958.

Testing steps

• Confirm that e.g. Quick Tags works as expected.
• Try to press the Trim Reblogs button on an original post, a reblog with no added content and only one trail item, and a post with enough content to trim.

[marcustyphoon]

(oh, and yes, I checked what happens if a user removes the disabled attribute and clicks the button; nothing bad occurs.)

[marcustyphoon]

Oh, major problem with this:

• fix quick tags popup closing when you press space

I guess you have focus of the button element once you click it and the spacebar clicks it again or something...? Not sure yet, help appreciated.

(if this is unsolvable, we could skip using the disabled attribute and the button entirely, and just not attach handlers to the button container element if the button should be disabled. this feels less elegant, however, as buttons cannot be toggled on or off at will in that case without messing with the handlers.)

[AprilSylph]

I guess you have focus of the button element once you click it and the spacebar clicks it again or something...?

Are we not stopping keydown propagation in the Quick Tags field? We should be doing that for every <input type="text"> we add to the page

[marcustyphoon]

Oh, I bet I know what's happening: because I attached the handlers to the button element without changing the handlers themselves, and they reference currentTarget, the popups are being placed inside the button element instead of inside the container. Pressing spacebar inside the popup is thus pressing spacebar with the focus inside a button.

This could be fixed either by changing scripts' togglePopupDisplay/onButtonClicked handlers to look at the parent element of the button, or just by not using disabled as mentioned above, which is honestly probably easier? But then if I were ever trying to toggle a button later, I would be like, "seriously, past me?"

[AprilSylph]

oh right, yeah, definitely do not put popups inside button elements. that's no good on multiple levels.

[AprilSylph]

Works well with the exception that I can sneak a peak of cursor: pointer when hovering the very edge of a disabled button. We should attach cursor: not-allowed to the element that is actually disabled.