Skip to content

Commit

Permalink
fix - Fixed printf command for "-"
Browse files Browse the repository at this point in the history
---

We've fixed the printf command in the release making workflow that refused
to work because of the "-" prefix, even when double-quoted.

---

Before

Before the fix is done, it would print a bogus error message.

  - printf "- SHA256 sum of bskyid (Windows): "

bash: printf: - : invalid option
printf: usage: printf [-v var] format [arguments]

After

The modified printf command causes the quoted text to be printed correctly

  - printf -- "- SHA256 sum of bskyid (Windows): "

- SHA256 sum of bskyid (Windows):

---

Type: fix
Breaking: False
Doc Required: False
Backport Required: False
Part: 1/1
  • Loading branch information
AptiviCEO committed Jan 14, 2025
1 parent aa6e2f5 commit 899856d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
cat CHANGES >> "$GITHUB_OUTPUT"
printf "\n- SHA256 sum of bskyid (Linux): " >> "$GITHUB_OUTPUT"
sha256sum src/bskyid >> "$GITHUB_OUTPUT"
printf "- SHA256 sum of bskyid (Windows): " >> "$GITHUB_OUTPUT"
printf -- "- SHA256 sum of bskyid (Windows): " >> "$GITHUB_OUTPUT"
sha256sum src/bskyid.ps1 >> "$GITHUB_OUTPUT"
echo 'EOF' >> "$GITHUB_OUTPUT"
- name: Release Making
Expand Down

0 comments on commit 899856d

Please sign in to comment.