Web api contract first as abstract controllers #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 14, 2017 10:04
…from ControllerTemplate
…nd GenerateAbstractController setting is added + created new test classes
…faces and GenerateAbstractController setting is added
GiampaLab
reviewed
Aug 14, 2017
| var code = codeGen.GenerateFile(); | ||
|
|
||
| //// Assert | ||
| Assert.IsTrue(code.Contains("abstract class TestController")); |
There was a problem hiding this comment.
Shouldn't this be Assert.IsFalse(code.Contains("abstract class TestController"));
| //// Act | ||
| var codeGen = new SwaggerToCSharpClientGenerator(document, new SwaggerToCSharpClientGeneratorSettings | ||
| { | ||
| GenerateControllerInterfaces = true, |
There was a problem hiding this comment.
Since you are testing only the abstract controller setting here I would keep GenerateControllerInterfaces = false
|
|
||
| //// Assert | ||
| Assert.IsTrue(code.Contains("abstract class TestController")); | ||
| Assert.IsTrue(code.Contains("abstract Foo")); |
| <# if (Model.WrapResponses){#> | ||
| var result = await _implementation.<#=operation.ActualOperationName#>Async(<#foreach(var parameter in operation.Parameters){#><#=parameter.VariableName#><#if(!parameter.IsLast){#>, <#}}#>); | ||
| var result = await _implementation.<#=operation.ActualOperationName#>Async(<#foreach(var parameter in operation.Parameters){#><#=parameter.VariableName#><# if(!parameter.IsLast){#>, <#}}#>); | ||
|
|
There was a problem hiding this comment.
You can probably revert formatting changes on this line and on lines 48 and 55 as well
added 4 commits
August 14, 2017 17:27
GiampaLab
approved these changes
Aug 15, 2017
…are deleted. ControllerGenerationFormat parameter is added. (default:partial)Test classes are deleted and new test class is added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WrapResponses bugfix - using System.Net.Http carried on FileTemplate
New futures added GenerateControllerInterfaces and GenerateAbstractController in SwaggerToCSharpControllerCommand and SwaggerToCSharpController